Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1504916 > unrolled thread
| Started by | Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> |
|---|---|
| First post | 2016-10-20 16:10 +0200 |
| Last post | 2016-10-20 16:10 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-10-20 16:10 +0200
| From | Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> |
|---|---|
| Date | 2016-10-20 16:10 +0200 |
| Subject | Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices |
| Message-ID | <sumcF-ed-3@gated-at.bofh.it> |
Ping? On Wed, Sep 21, 2016 at 10:26 AM, Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> wrote: > Hi > >>> >>> Unsinged long is more than enough for s3an. I think v7 is ok. >> >> Then, why did you change the spi_nor_s3an_addr_convert() prototype? >> > > Because it is used in spi_nor_read and spi_nor_write, which use loff_t. > > I think it is more clean to have only one comment explaining the max > size of the s3an, instead of having them scattered around. But if > think that it is better to have unsinged int as prototype I have no > problem in changing it. > > Regards! > > > -- > Ricardo Ribalda -- Ricardo Ribalda
Back to top | Article view | linux.kernel
csiph-web