Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

From	Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices
Date	2016-10-20 16:10 +0200
Message-ID	<sumcF-ed-3@gated-at.bofh.it> (permalink)
References	(2 earlier) <sjKBH-6bG-25@gated-at.bofh.it> <sjKV3-6zb-3@gated-at.bofh.it> <sjKV3-6zb-1@gated-at.bofh.it> <sjL4J-6Cq-9@gated-at.bofh.it> <sjL4J-6Cq-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Ping?

On Wed, Sep 21, 2016 at 10:26 AM, Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:
> Hi
>
>>>
>>> Unsinged long is more than enough for s3an. I think v7 is ok.
>>
>> Then, why did you change the spi_nor_s3an_addr_convert() prototype?
>>
>
> Because it is used in spi_nor_read and spi_nor_write, which use loff_t.
>
> I think it is more clean to have only one comment explaining the max
> size of the s3an, instead of having them scattered around. But if
> think that it is better to have unsinged int as prototype I have no
> problem in changing it.
>
> Regards!
>
>
> --
> Ricardo Ribalda



-- 
Ricardo Ribalda

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-10-20 16:10 +0200

csiph-web