Groups > linux.kernel > #1501906

Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller
Date	Mon, 17 Oct 2016 13:50:01 +0200
Message-ID	<steAx-2Ua-13@gated-at.bofh.it> (permalink)
References	<soU7n-1nW-7@gated-at.bofh.it> <stanf-mk-1@gated-at.bofh.it> <staGB-sN-7@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1476704355; bh=7vRk4LbIerMvWMtHyWrc4sBoKgbVlTFhHQSqEKp+VMY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q8hVzHK4zCTgb+eH3X/9Y1uPhWYzn4L/qNaV6wJkbHKsBjqDy7RF+d/FVWZYeeBw1 O8/JBcXwzTMeQ1/O8C/f52zWNm38BZ9wzUttD6IG9zIeTJjvo7dd5z0DbQVyQwa4uA FRjT2zHHiyvLTxRivWuKUQD9OrRROx8dGuLbROBs=
User-Agent	KMail/4.14.10 (Linux/4.4.6-gentoo; KDE/4.14.24; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	48
Organization	linux.* mail to news gateway
X-Original-Cc	Sekhar Nori <nsekhar@ti.com>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Kevin Hilman <khilman@baylibre.com>, Michael Turquette <mturquette@baylibre.com>, Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>, Mark Rutland <mark.rutland@arm.com>, Peter Ujfalusi <peter.ujfalusi@ti.com>, Russell King <linux@armlinux.org.uk>, Karl Beldan <karl.beldan@gmail.com>, LKML <linux-kernel@vger.kernel.org>, arm-soc <linux-arm-kernel@lists.infradead.org>, linux-drm <dri-devel@lists.freedesktop.org>, linux-devicetree <devicetree@vger.kernel.org>, Jyri Sarha <jsarha@ti.com>, David Airlie <airlied@linux.ie>, Maxime Ripard <maxime.ripard@free-electrons.com>, Karl Beldan <kbeldan@baylibre.com>
X-Original-Date	Mon, 17 Oct 2016 14:40 +0300
X-Original-Message-ID	<4975084.EGQPv58AK6@avalon>
X-Original-References	<1475672732-17111-1-git-send-email-bgolaszewski@baylibre.com> <65fde145-0820-794d-d345-621f66cdacc0@ti.com> <7a2ffcd0-fe1d-c887-53b7-7cb5e1e61222@ti.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1501906

Show key headers only | View raw

Hello,

On Monday 17 Oct 2016 10:33:58 Tomi Valkeinen wrote:
> On 17/10/16 10:12, Sekhar Nori wrote:
>> On Monday 17 October 2016 11:26 AM, Tomi Valkeinen wrote:
>>> On 15/10/16 20:42, Sekhar Nori wrote:
>>>>> diff --git a/arch/arm/boot/dts/da850.dtsi
>>>>> b/arch/arm/boot/dts/da850.dtsi
>>>>> index f79e1b9..32908ae 100644
>>>>> --- a/arch/arm/boot/dts/da850.dtsi
>>>>> +++ b/arch/arm/boot/dts/da850.dtsi
>>>>> @@ -399,6 +420,14 @@
>>>>>  				<&edma0 0 1>;
>>>>>  			dma-names = "tx", "rx";
>>>>>  		};
>>>>> +
>>>>> +		display: display@213000 {
>>>>> +			compatible = "ti,am33xx-tilcdc", "ti,da850-tilcdc";
>>>> 
>>>> This should instead be:
>>>> 
>>>> compatible = "ti,da850-tilcdc", "ti,am33xx-tilcdc";
>>>> 
>>>> as the closest match should appear first in the list.
>>> 
>>> Actually I don't think that's correct. The LCDC on da850 is not
>>> compatible with the LCDC on AM335x. I think it should be just
>>> "ti,da850-tilcdc".
>> 
>> So if "ti,am33xx-tilcdc" is used, the display wont work at all? If thats
>> the case, I wonder how the patch passed testing. Bartosz?
> 
> AM3 has "version 2" of LCDC, whereas DA850 is v1. They are quite
> similar, but different.
> 
> The driver gets the version number from LCDC's register, and acts based
> on that, so afaik the compatible string doesn't really affect the
> functionality (as long as it matches).
> 
> But even if it works with the current driver, I don't think
> "ti,am33xx-tilcdc" and "ti,da850-tilcdc" are compatible in the HW level.

If the hardware provides IP revision information, how about just "ti,lcdc" ?

-- 
Regards,

Laurent Pinchart

Thread

Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Sekhar Nori <nsekhar@ti.com> - 2016-10-15 19:50 +0200
  Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-10-15 21:50 +0200
  Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-10-17 08:00 +0200
    Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Sekhar Nori <nsekhar@ti.com> - 2016-10-17 09:20 +0200
      Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-10-17 09:30 +0200
      Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-10-17 09:40 +0200
        Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-10-17 13:50 +0200
          Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-10-17 14:40 +0200
            Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-10-17 14:50 +0200
            Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-10-17 16:10 +0200
              Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Sekhar Nori <nsekhar@ti.com> - 2016-10-20 12:10 +0200
                Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-10-20 12:30 +0200
                Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Sekhar Nori <nsekhar@ti.com> - 2016-10-20 12:40 +0200

csiph-web