Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1501334
| From | Sekhar Nori <nsekhar@ti.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller |
| Date | 2016-10-15 19:50 +0200 |
| Message-ID | <ssBfQ-2lp-7@gated-at.bofh.it> (permalink) |
| References | <soU7n-1nW-7@gated-at.bofh.it> <soU7n-1nW-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wednesday 05 October 2016 06:35 PM, Bartosz Golaszewski wrote:
> From: Karl Beldan <kbeldan@baylibre.com>
>
> Add pins used by the LCD controller and a disabled LCDC node to be
> reused in device trees including da850.dtsi.
>
> Signed-off-by: Karl Beldan <kbeldan@baylibre.com>
> [Bartosz:
> - added the commit description
> - changed the dt node name to a generic one
> - added a da850-specific compatible string
> - removed the tilcdc,panel node
> - moved the pins definitions to da850.dtsi as suggested by
> Sekhar Nori (was in: da850-lcdk.dts)]
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> arch/arm/boot/dts/da850.dtsi | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
> index f79e1b9..32908ae 100644
> --- a/arch/arm/boot/dts/da850.dtsi
> +++ b/arch/arm/boot/dts/da850.dtsi
> @@ -399,6 +420,14 @@
> <&edma0 0 1>;
> dma-names = "tx", "rx";
> };
> +
> + display: display@213000 {
> + compatible = "ti,am33xx-tilcdc", "ti,da850-tilcdc";
This should instead be:
compatible = "ti,da850-tilcdc", "ti,am33xx-tilcdc";
as the closest match should appear first in the list.
> + reg = <0x213000 0x1000>;
> + interrupt-parent = <&intc>
No need of specifying the interrupt-parent as it is assumed to be that
from the parent node (soc) if left unspecified.
I made these two fixes locally and pushed the two patches in this series
to v4.10/dt branch of my tree (for URL see MAINTAINERS). Can you take a
look and make sure I did not mess anything up?
Regards,
Sekhar
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Sekhar Nori <nsekhar@ti.com> - 2016-10-15 19:50 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-10-15 21:50 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-10-17 08:00 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Sekhar Nori <nsekhar@ti.com> - 2016-10-17 09:20 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-10-17 09:30 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-10-17 09:40 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-10-17 13:50 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-10-17 14:40 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-10-17 14:50 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-10-17 16:10 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Sekhar Nori <nsekhar@ti.com> - 2016-10-20 12:10 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-10-20 12:30 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Sekhar Nori <nsekhar@ti.com> - 2016-10-20 12:40 +0200
csiph-web