Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1501643
| From | Sekhar Nori <nsekhar@ti.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller |
| Date | 2016-10-17 09:20 +0200 |
| Message-ID | <stanf-mk-1@gated-at.bofh.it> (permalink) |
| References | <soU7n-1nW-7@gated-at.bofh.it> <soU7n-1nW-17@gated-at.bofh.it> <ssBfQ-2lp-7@gated-at.bofh.it> <st97Q-7NQ-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Monday 17 October 2016 11:26 AM, Tomi Valkeinen wrote:
> On 15/10/16 20:42, Sekhar Nori wrote:
>
>>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>>> index f79e1b9..32908ae 100644
>>> --- a/arch/arm/boot/dts/da850.dtsi
>>> +++ b/arch/arm/boot/dts/da850.dtsi
>>
>>> @@ -399,6 +420,14 @@
>>> <&edma0 0 1>;
>>> dma-names = "tx", "rx";
>>> };
>>> +
>>> + display: display@213000 {
>>> + compatible = "ti,am33xx-tilcdc", "ti,da850-tilcdc";
>>
>> This should instead be:
>>
>> compatible = "ti,da850-tilcdc", "ti,am33xx-tilcdc";
>>
>> as the closest match should appear first in the list.
>
> Actually I don't think that's correct. The LCDC on da850 is not
> compatible with the LCDC on AM335x. I think it should be just
> "ti,da850-tilcdc".
So if "ti,am33xx-tilcdc" is used, the display wont work at all? If thats
the case, I wonder how the patch passed testing. Bartosz?
Thanks,
Sekhar
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Sekhar Nori <nsekhar@ti.com> - 2016-10-15 19:50 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-10-15 21:50 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-10-17 08:00 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Sekhar Nori <nsekhar@ti.com> - 2016-10-17 09:20 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-10-17 09:30 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-10-17 09:40 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-10-17 13:50 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-10-17 14:40 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-10-17 14:50 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-10-17 16:10 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Sekhar Nori <nsekhar@ti.com> - 2016-10-20 12:10 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-10-20 12:30 +0200
Re: [PATCH 2/2] ARM: dts: da850: add a node for the LCD controller Sekhar Nori <nsekhar@ti.com> - 2016-10-20 12:40 +0200
csiph-web