Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa: remove the limitation that cpu0 must bind to node0")

From	"Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Newsgroups	linux.kernel
Subject	Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa: remove the limitation that cpu0 must bind to node0")
Date	2016-10-17 11:00 +0200
Message-ID	<stbW2-1d0-17@gated-at.bofh.it> (permalink)
References	(2 earlier) <ssaIF-1MD-1@gated-at.bofh.it> <sschr-2Xb-1@gated-at.bofh.it> <sscAN-33Q-3@gated-at.bofh.it> <sscUa-3ay-15@gated-at.bofh.it> <ssdwS-3Da-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


>> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
>> index d3f151cfd4a1..8507703dabe4 100644
>> --- a/arch/arm64/kernel/smp.c
>> +++ b/arch/arm64/kernel/smp.c
>> @@ -544,6 +544,7 @@ acpi_map_gic_cpu_interface(struct acpi_madt_generic_interrupt *processor)
>>  			return;
>>  		}
>>  		bootcpu_valid = true;
>> +		early_map_cpu_to_node(0, acpi_numa_get_nid(0, hwid));
>>  		return;
>>  	}
>>
> 
> Anyway, your patch works with both the two-node NUMA configuration Drew suggested for testing, and with the single-node config that I originally used for the bisection. Therefore:
> 
> Tested-by: Laszlo Ersek <lersek@redhat.com>
> Reported-by: Laszlo Ersek <lersek@redhat.com>
> 
> Thank you very much for the quick bugfix! And, I think your patch (when you send it for real) should carry
I'm so sorry about this. My patch series prepared before ACPI NUMA upstreamed, and forgot considering it in later.

> 
> Fixes: 7ba5f605f3a0d9495aad539eeb8346d726dfc183
> 
> too, because it supplies the cpu#0<->node#xxx association that 7ba5f605f3a0 removed not just for DT, but also for ACPI.
> 
> Cheers!
> Laszlo
> 
> .
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Laszlo Ersek <lersek@redhat.com> - 2016-10-14 01:00 +0200
  Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Andrew Jones <drjones@redhat.com> - 2016-10-14 10:10 +0200
    Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Laszlo Ersek <lersek@redhat.com> - 2016-10-14 15:30 +0200
      Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Andrew Jones <drjones@redhat.com> - 2016-10-14 15:50 +0200
        Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Laszlo Ersek <lersek@redhat.com> - 2016-10-14 17:50 +0200
      Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Laszlo Ersek <lersek@redhat.com> - 2016-10-14 17:10 +0200
        Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Laszlo Ersek <lersek@redhat.com> - 2016-10-14 17:30 +0200
          Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-10-14 17:50 +0200
            Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Laszlo Ersek <lersek@redhat.com> - 2016-10-14 18:30 +0200
              Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-10-14 19:00 +0200
              Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2016-10-17 11:00 +0200

csiph-web