Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa: remove the limitation that cpu0 must bind to node0")

From	Laszlo Ersek <lersek@redhat.com>
Newsgroups	linux.kernel
Subject	Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa: remove the limitation that cpu0 must bind to node0")
Date	2016-10-14 17:30 +0200
Message-ID	<sscAN-33Q-3@gated-at.bofh.it> (permalink)
References	<srX8L-1in-71@gated-at.bofh.it> <ss5IZ-7as-5@gated-at.bofh.it> <ssaIF-1MD-1@gated-at.bofh.it> <sschr-2Xb-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/14/16 17:01, Laszlo Ersek wrote:

> Maybe the code I
> tried to analyze in this email was never *meant* to associate CPU#0 with
> any NUMA node at all (not even node 0); instead, other code -- for
> example code removed by 7ba5f605f3a0 -- was meant to perform that
> association.

Staring a bit more at the code, this looks very likely; in acpi_map_gic_cpu_interface() we have

> 	/* Check if GICC structure of boot CPU is available in the MADT */
> 	if (cpu_logical_map(0) == hwid) {
> 		if (bootcpu_valid) {
> 			pr_err("duplicate boot CPU MPIDR: 0x%llx in MADT\n",
> 			       hwid);
> 			return;
> 		}
> 		bootcpu_valid = true;
> 		return;
> 	}

which means that this callback function (for parsing the GICC structures in the MADT) expects to find the boot processor as well.

Upon finding the boot processor, we set bootcpu_valid to true, and that's it -- no association with any NUMA node, and no incrementing of "cpu_count".

Thanks
Laszlo

Thread

aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Laszlo Ersek <lersek@redhat.com> - 2016-10-14 01:00 +0200
  Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Andrew Jones <drjones@redhat.com> - 2016-10-14 10:10 +0200
    Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Laszlo Ersek <lersek@redhat.com> - 2016-10-14 15:30 +0200
      Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Andrew Jones <drjones@redhat.com> - 2016-10-14 15:50 +0200
        Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Laszlo Ersek <lersek@redhat.com> - 2016-10-14 17:50 +0200
      Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Laszlo Ersek <lersek@redhat.com> - 2016-10-14 17:10 +0200
        Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Laszlo Ersek <lersek@redhat.com> - 2016-10-14 17:30 +0200
          Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-10-14 17:50 +0200
            Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Laszlo Ersek <lersek@redhat.com> - 2016-10-14 18:30 +0200
              Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-10-14 19:00 +0200
              Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2016-10-17 11:00 +0200

csiph-web