Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1501070

Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa: remove the limitation that cpu0 must bind to node0")

Show all headers | View raw

On Fri, Oct 14, 2016 at 05:27:58PM +0200, Laszlo Ersek wrote:
> On 10/14/16 17:01, Laszlo Ersek wrote:
> 
> > Maybe the code I
> > tried to analyze in this email was never *meant* to associate CPU#0 with
> > any NUMA node at all (not even node 0); instead, other code -- for
> > example code removed by 7ba5f605f3a0 -- was meant to perform that
> > association.
> 
> Staring a bit more at the code, this looks very likely; in acpi_map_gic_cpu_interface() we have
> 
> > 	/* Check if GICC structure of boot CPU is available in the MADT */
> > 	if (cpu_logical_map(0) == hwid) {
> > 		if (bootcpu_valid) {
> > 			pr_err("duplicate boot CPU MPIDR: 0x%llx in MADT\n",
> > 			       hwid);
> > 			return;
> > 		}
> > 		bootcpu_valid = true;
> > 		return;
> > 	}
> 
> which means that this callback function (for parsing the GICC
> structures in the MADT) expects to find the boot processor as well.
> 
> Upon finding the boot processor, we set bootcpu_valid to true, and
> that's it -- no association with any NUMA node, and no incrementing of
> "cpu_count".

Yes, because that's to check the MADT contains the boot cpu hwid.

Does this help (compile tested only) ?

-- >8 -- 
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index d3f151c..8507703 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -544,6 +544,7 @@ static int __init smp_cpu_setup(int cpu)
 			return;
 		}
 		bootcpu_valid = true;
+		early_map_cpu_to_node(0, acpi_numa_get_nid(0, hwid));
 		return;
 	}
 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Laszlo Ersek <lersek@redhat.com> - 2016-10-14 01:00 +0200
  Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Andrew Jones <drjones@redhat.com> - 2016-10-14 10:10 +0200
    Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Laszlo Ersek <lersek@redhat.com> - 2016-10-14 15:30 +0200
      Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Andrew Jones <drjones@redhat.com> - 2016-10-14 15:50 +0200
        Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Laszlo Ersek <lersek@redhat.com> - 2016-10-14 17:50 +0200
      Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Laszlo Ersek <lersek@redhat.com> - 2016-10-14 17:10 +0200
        Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Laszlo Ersek <lersek@redhat.com> - 2016-10-14 17:30 +0200
          Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-10-14 17:50 +0200
            Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Laszlo Ersek <lersek@redhat.com> - 2016-10-14 18:30 +0200
              Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-10-14 19:00 +0200
              Re: aarch64 ACPI boot regressed by commit 7ba5f605f3a0 ("arm64/numa:  remove the limitation that cpu0 must bind to node0") "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2016-10-17 11:00 +0200

csiph-web