Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1501032

Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack

From Ard Biesheuvel <ard.biesheuvel@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack
Date 2016-10-14 16:30 +0200
Message-ID <ssbEK-2pQ-9@gated-at.bofh.it> (permalink)
References (1 earlier) <ssaz0-1Ja-11@gated-at.bofh.it> <ssaz0-1Ja-13@gated-at.bofh.it> <ssaz0-1Ja-15@gated-at.bofh.it> <ssaz0-1Ja-9@gated-at.bofh.it> <ssb22-1TI-49@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

> On 14 Oct 2016, at 14:46, Johannes Berg <johannes@sipsolutions.net> wrote:
> 
> 
>> 
>> Is the aad[] actually reused? I would assume it only affects the mac
>> on encryption, and the verification on decryption but I don't think
>> we actually need it back from the crypto routines.
> 
> I don't think it's reused.
> 
>> Exactly what you said above :-) My patch only touches CCM but as you
>> said,
>> 
>> """
>> 'Also there's B_0/J_0 for CCM/GCM, and the 'zero' thing that GMAC
>> has.
>> """
> 
> Ah, but we can/should do the same for the others, no?
> 

Yes, but then we end up kmalloc/kfreeing chunks of 16 bytes, which is actually another problem.

I still think we are not violating the api by putting aead_req on the stack (but herbert should confirm). The aad[] issue does violate the api, so it deserves a separate fix imo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mac80211: aes_ccm: move struct aead_req off the stack Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 15:10 +0200
  Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 15:20 +0200
    Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 15:50 +0200
      Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 16:30 +0200
  Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 15:20 +0200
    Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 15:50 +0200
  Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 15:20 +0200
  Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 15:20 +0200

csiph-web