Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1500961
| From | Ard Biesheuvel <ard.biesheuvel@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack |
| Date | 2016-10-14 15:20 +0200 |
| Message-ID | <ssaz0-1Ja-9@gated-at.bofh.it> (permalink) |
| References | <ssapj-1FC-1@gated-at.bofh.it> <ssaz0-1Ja-11@gated-at.bofh.it> <ssaz0-1Ja-13@gated-at.bofh.it> <ssaz0-1Ja-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 14 October 2016 at 14:15, Johannes Berg <johannes@sipsolutions.net> wrote: > On Fri, 2016-10-14 at 14:13 +0100, Ard Biesheuvel wrote: >> >> > But if we allocate things anyway, is it worth expending per-CPU >> > buffers on these? >> >> Ehmm, maybe not. I could spin a v2 that allocates a bigger buffer, >> and copies aad[] into it as well > > Copies in/out, I guess. Also there's B_0/J_0 for CCM/GCM, and the > 'zero' thing that GMAC has. > Is the aad[] actually reused? I would assume it only affects the mac on encryption, and the verification on decryption but I don't think we actually need it back from the crypto routines. >> That does not help the other algos though > > What do you mean? > Exactly what you said above :-) My patch only touches CCM but as you said, """ 'Also there's B_0/J_0 for CCM/GCM, and the 'zero' thing that GMAC has. """
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] mac80211: aes_ccm: move struct aead_req off the stack Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 15:10 +0200
Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 15:20 +0200
Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 15:50 +0200
Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 16:30 +0200
Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 15:20 +0200
Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 15:50 +0200
Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 15:20 +0200
Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 15:20 +0200
csiph-web