Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack

From	Johannes Berg <johannes@sipsolutions.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack
Date	2016-10-14 15:20 +0200
Message-ID	<ssaz0-1Ja-11@gated-at.bofh.it> (permalink)
References	<ssapj-1FC-1@gated-at.bofh.it> <ssaz0-1Ja-27@gated-at.bofh.it> <ssapj-1FC-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> So use kzalloc

Do we really need kzalloc()? We have things on the stack right now, and
don't initialize, so surely we don't really need to zero things?

> This only addresses one half of the problem. The other problem, i.e.,
> the fact that the aad[] array lives on the stack of the caller, is
> handled adequately imo by the change proposed by Johannes.

But if we allocate things anyway, is it worth expending per-CPU buffers
on these?

johannes

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mac80211: aes_ccm: move struct aead_req off the stack Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 15:10 +0200
  Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 15:20 +0200
    Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 15:50 +0200
      Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 16:30 +0200
  Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-10-14 15:20 +0200
    Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 15:50 +0200
  Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 15:20 +0200
  Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Johannes Berg <johannes@sipsolutions.net> - 2016-10-14 15:20 +0200

csiph-web