Re: [PATCH 4/4] virtio_blk: Rename a jump label in virtblk_get_id()

From	"Michael S. Tsirkin" <mst@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] virtio_blk: Rename a jump label in virtblk_get_id()
Date	2016-10-10 01:40 +0200
Message-ID	<sqvRf-28d-1@gated-at.bofh.it> (permalink)
References	<qEuGl-43C-5@gated-at.bofh.it> <sgUQW-1IH-7@gated-at.bofh.it> <sgUQW-1IH-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 13, 2016 at 02:15:20PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 13 Sep 2016 13:50:56 +0200
> 
> Adjust a jump label according to the current Linux coding style convention.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Please don't send me such patches, I'm not really
interested in renaming labels unless it clearly adds
to a significant improvement in readability.

> ---
>  drivers/block/virtio_blk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
> index 696f452..fef2bd0 100644
> --- a/drivers/block/virtio_blk.c
> +++ b/drivers/block/virtio_blk.c
> @@ -247,10 +247,10 @@ static int virtblk_get_id(struct gendisk *disk, char *id_str)
>  
>  	err = blk_rq_map_kern(q, req, id_str, VIRTIO_BLK_ID_BYTES, GFP_KERNEL);
>  	if (err)
> -		goto out;
> +		goto put_request;
>  
>  	err = blk_execute_rq(vblk->disk->queue, vblk->disk, req, false);
> -out:
> + put_request:
>  	blk_put_request(req);
>  	return err;
>  }
> -- 
> 2.10.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 4/4] virtio_blk: Rename a jump label in virtblk_get_id() "Michael S. Tsirkin" <mst@redhat.com> - 2016-10-10 01:40 +0200
  Re: virtio_blk: Rename a jump label in virtblk_get_id() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-10 10:30 +0200

csiph-web