Re: [PATCH] irqchip/jcore: fix lost per-cpu interrupts

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] irqchip/jcore: fix lost per-cpu interrupts
Date	2016-10-10 01:40 +0200
Message-ID	<sqvRf-28d-3@gated-at.bofh.it> (permalink)
References	<sqfjr-cU-7@gated-at.bofh.it> <sqk9s-3ro-7@gated-at.bofh.it> <sqnAl-5tK-23@gated-at.bofh.it> <sqrXj-8gb-9@gated-at.bofh.it> <squsa-1oi-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, 9 Oct 2016, Rich Felker wrote:
> On Sun, Oct 09, 2016 at 09:23:58PM +0200, Thomas Gleixner wrote:
> > Well, you can use handle_percpu_irq() for your device interrupts if you
> > guarantee at the hardware level that there is no reentrancy.
> 
> Reentrancy is possible of course if the kernel enables irqs during the
> irq handler. Is not doing so a stable part of the kernel irq
> subsystem? My understanding is that modern kernels keep irqs disabled
> for the full duration of (hard) irq handlers.

If you enable lockdep then it will yell at offenders which enable irqs in
the interrupt handler. So yes, hard irq handlers are not allowed to
reenable interrupts.
 
> > Once you make
> > the hardware capable of delivering them on either core the picture changes.
> 
> *nod* Perhaps if/when we do that, the path of least resistence would
> be to adjust the irq numbering so that percpu (i.e., hard-routed to a
> particular cpu) and global irqs (deliverable on any core) are in
> different ranges and the existing kernel frameworks work.

That's very much what ARM and others do.

Thanks,

	tglx

Thread

[PATCH] irqchip/jcore: fix lost per-cpu interrupts Rich Felker <dalias@libc.org> - 2016-10-09 08:00 +0200
  Re: [PATCH] irqchip/jcore: fix lost per-cpu interrupts Thomas Gleixner <tglx@linutronix.de> - 2016-10-09 13:10 +0200
    Re: [PATCH] irqchip/jcore: fix lost per-cpu interrupts Rich Felker <dalias@libc.org> - 2016-10-09 16:50 +0200
      Re: [PATCH] irqchip/jcore: fix lost per-cpu interrupts Thomas Gleixner <tglx@linutronix.de> - 2016-10-09 21:30 +0200
        Re: [PATCH] irqchip/jcore: fix lost per-cpu interrupts Rich Felker <dalias@libc.org> - 2016-10-10 00:10 +0200
          Re: [PATCH] irqchip/jcore: fix lost per-cpu interrupts Thomas Gleixner <tglx@linutronix.de> - 2016-10-10 01:40 +0200
        Re: [PATCH] irqchip/jcore: fix lost per-cpu interrupts Rich Felker <dalias@libc.org> - 2016-10-11 17:30 +0200
          Re: [PATCH] irqchip/jcore: fix lost per-cpu interrupts Thomas Gleixner <tglx@linutronix.de> - 2016-10-12 10:30 +0200
            Re: [PATCH] irqchip/jcore: fix lost per-cpu interrupts Rich Felker <dalias@libc.org> - 2016-10-12 18:40 +0200
              Re: [PATCH] irqchip/jcore: fix lost per-cpu interrupts "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-10-12 22:40 +0200
                Re: [PATCH] irqchip/jcore: fix lost per-cpu interrupts Rich Felker <dalias@libc.org> - 2016-10-13 00:20 +0200

csiph-web