Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS

Path	csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!news.unit0.net!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Alan Stern <stern@rowland.harvard.edu>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS
Date	Sun, 09 Oct 2016 23:20:01 +0200
Message-ID	<sqtFL-RQ-3@gated-at.bofh.it> (permalink)
References	<sqpiN-6z5-1@gated-at.bofh.it>
X-Original-To	Krzysztof Kozlowski <krzk@kernel.org>
X-X-Sender	stern@netrider.rowland.org
MIME-Version	1.0
Content-Type	TEXT/PLAIN; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	Anand Moon <linux.amoon@gmail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Kukjin Kim <kgene@kernel.org>, Javier Martinez Canillas <javier@osg.samsung.com>, <linux-usb@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-samsung-soc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
X-Original-Date	Sun, 9 Oct 2016 17:17:15 -0400 (EDT)
X-Original-Message-ID	<Pine.LNX.4.44L0.1610091713490.1734-100000@netrider.rowland.org>
X-Original-References	<20161009163446.GA9672@kozik-lap>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1498015

Show key headers only | View raw

On Sun, 9 Oct 2016, Krzysztof Kozlowski wrote:

> On Sun, Oct 09, 2016 at 02:34:14PM +0000, Anand Moon wrote:
> > Move the ehci-exynos system PM callbacks within #ifdef CONFIG_PM_SLEEP
> > as to avoid them being build when not used. This also allows us to use the
> > SET_SYSTEM_SLEEP_PM_OPS macro which simplifies the code.
> > 
> > Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> > ---
> >  drivers/usb/host/ehci-exynos.c | 14 ++++++--------
> >  1 file changed, 6 insertions(+), 8 deletions(-)
> > 
> > diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
> > index 42e5b66..1899900 100644
> > --- a/drivers/usb/host/ehci-exynos.c
> > +++ b/drivers/usb/host/ehci-exynos.c
> > @@ -251,7 +251,7 @@ static int exynos_ehci_remove(struct platform_device *pdev)
> >  	return 0;
> >  }
> >  
> > -#ifdef CONFIG_PM
> > +#ifdef CONFIG_PM_SLEEP
> 
> Does not look like an equivalent change. How will it behave in a config
> with !SUSPEND && !HIBERNATE && PM?

It's hard to say what Anand originally had in mind.  To me, it looks
like it will behave exactly the same as before, the only difference
being that the object image will not contain unused exynos_ehci_suspend
and exynos_ehci_resume routines.  And the compiler won't issue a 
warning at build time that the routines are unused.

Alan Stern

Thread

[PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS Anand Moon <linux.amoon@gmail.com> - 2016-10-09 17:00 +0200
  Re: [PATCH 1/2] host: ehci-exynos: Convert to use the  SET_SYSTEM_SLEEP_PM_OPS Krzysztof Kozlowski <krzk@kernel.org> - 2016-10-09 18:40 +0200
    Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS Anand Moon <linux.amoon@gmail.com> - 2016-10-09 19:20 +0200
      Re: [PATCH 1/2] host: ehci-exynos: Convert to use the  SET_SYSTEM_SLEEP_PM_OPS Krzysztof Kozlowski <krzk@kernel.org> - 2016-10-09 19:30 +0200
        Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS Anand Moon <linux.amoon@gmail.com> - 2016-10-09 20:30 +0200
          Re: [PATCH 1/2] host: ehci-exynos: Convert to use the  SET_SYSTEM_SLEEP_PM_OPS Krzysztof Kozlowski <krzk@kernel.org> - 2016-10-09 21:00 +0200
            Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS Anand Moon <linux.amoon@gmail.com> - 2016-10-09 21:20 +0200
    Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS Alan Stern <stern@rowland.harvard.edu> - 2016-10-09 23:20 +0200
      Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS Anand Moon <linux.amoon@gmail.com> - 2016-10-10 16:20 +0200

csiph-web