Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS

From	Alan Stern <stern@rowland.harvard.edu>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS
Date	2016-10-09 23:20 +0200
Message-ID	<sqtFL-RQ-3@gated-at.bofh.it> (permalink)
References	<sqpiN-6z5-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, 9 Oct 2016, Krzysztof Kozlowski wrote:

> On Sun, Oct 09, 2016 at 02:34:14PM +0000, Anand Moon wrote:
> > Move the ehci-exynos system PM callbacks within #ifdef CONFIG_PM_SLEEP
> > as to avoid them being build when not used. This also allows us to use the
> > SET_SYSTEM_SLEEP_PM_OPS macro which simplifies the code.
> > 
> > Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> > ---
> >  drivers/usb/host/ehci-exynos.c | 14 ++++++--------
> >  1 file changed, 6 insertions(+), 8 deletions(-)
> > 
> > diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
> > index 42e5b66..1899900 100644
> > --- a/drivers/usb/host/ehci-exynos.c
> > +++ b/drivers/usb/host/ehci-exynos.c
> > @@ -251,7 +251,7 @@ static int exynos_ehci_remove(struct platform_device *pdev)
> >  	return 0;
> >  }
> >  
> > -#ifdef CONFIG_PM
> > +#ifdef CONFIG_PM_SLEEP
> 
> Does not look like an equivalent change. How will it behave in a config
> with !SUSPEND && !HIBERNATE && PM?

It's hard to say what Anand originally had in mind.  To me, it looks
like it will behave exactly the same as before, the only difference
being that the object image will not contain unused exynos_ehci_suspend
and exynos_ehci_resume routines.  And the compiler won't issue a 
warning at build time that the routines are unused.

Alan Stern

Thread

[PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS Anand Moon <linux.amoon@gmail.com> - 2016-10-09 17:00 +0200
  Re: [PATCH 1/2] host: ehci-exynos: Convert to use the  SET_SYSTEM_SLEEP_PM_OPS Krzysztof Kozlowski <krzk@kernel.org> - 2016-10-09 18:40 +0200
    Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS Anand Moon <linux.amoon@gmail.com> - 2016-10-09 19:20 +0200
      Re: [PATCH 1/2] host: ehci-exynos: Convert to use the  SET_SYSTEM_SLEEP_PM_OPS Krzysztof Kozlowski <krzk@kernel.org> - 2016-10-09 19:30 +0200
        Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS Anand Moon <linux.amoon@gmail.com> - 2016-10-09 20:30 +0200
          Re: [PATCH 1/2] host: ehci-exynos: Convert to use the  SET_SYSTEM_SLEEP_PM_OPS Krzysztof Kozlowski <krzk@kernel.org> - 2016-10-09 21:00 +0200
            Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS Anand Moon <linux.amoon@gmail.com> - 2016-10-09 21:20 +0200
    Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS Alan Stern <stern@rowland.harvard.edu> - 2016-10-09 23:20 +0200
      Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS Anand Moon <linux.amoon@gmail.com> - 2016-10-10 16:20 +0200

csiph-web