Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1497313

[PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger

Path csiph.com!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From Laura Abbott <labbott@redhat.com>
Newsgroups linux.kernel
Subject [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger
Date Fri, 07 Oct 2016 18:10:01 +0200
Message-ID <spFSF-2Rh-29@gated-at.bofh.it> (permalink)
References <spqK3-85w-15@gated-at.bofh.it>
X-Original-To Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh@kernel.org>, Arnd Bergmann <arnd@arndb.de>
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to; bh=NrS/wXN4MJ5ICsgKGmbs6CYN2UEMfh+VZajiyKAnmqo=; b=ORCsKEFYUIh6WDYEdRr4boxbxUVkowNgsdFUUIpGpvQCm3wNM/2pfFJjQMoi/nQoOG +WTi6qC+MIsn9md4GhVidteWIdPiCJ/BoVCoPOfEqjDRYjAhjXv8IseS/4alKyB8gql7 PckLVg35/BiclBkeYnQixL0m5o/19oD9kQn3s5G3c8p9Dh6Ahs1OyoX5j8cTCpm0kBdp cPKBxYYB5qdxOeByPuvcdJYOL9YzKaHil+DbtUnyjAkkDnAwZ5VAy17zG2vSQX9Qwmp7 /XSskoLsoqOgwcNfPyghNj73uIb4TzPvLVaJSEg/9bmrzU3RHtdNODy5CXHSqD83OhFh XfgQ==
X-Gm-Message-State AA6/9RnvmR/gpmhRLOG6nDLCAXOfdq4/2V3K5OuqoMfHkxwUTN7E0QsHKHOty5aAlrO3Wjlj
X-Received by 10.36.88.209 with SMTP id f200mr21659405itb.44.1475856576732; Fri, 07 Oct 2016 09:09:36 -0700 (PDT)
X-Mailer git-send-email 2.7.4
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 37
Organization linux.* mail to news gateway
X-Original-Cc Laura Abbott <labbott@redhat.com>, linux-kernel@vger.kernel.org
X-Original-Date Fri, 7 Oct 2016 09:09:30 -0700
X-Original-Message-ID <1475856570-10743-1-git-send-email-labbott@redhat.com>
X-Original-References <120f00f2-94b6-aead-7bb4-9917bc338660@redhat.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1497313

Show key headers only | View raw


The current state of driver removal is not great.
CONFIG_DEBUG_TEST_DRIVER_REMOVE finds lots of errors. The help text
currently undersells exactly how many errors this option will find. Add
a bit more description to indicate this option shouldn't be turned on
unless you actually want to debug driver removal. The text can be
changed later when more drivers are fixed up.

Signed-off-by: Laura Abbott <labbott@redhat.com>
---
 drivers/base/Kconfig | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index fdf44ca..d02e7c0 100644
--- a/drivers/base/Kconfig
+++ b/drivers/base/Kconfig
@@ -213,14 +213,16 @@ config DEBUG_DEVRES
 	  If you are unsure about this, Say N here.
 
 config DEBUG_TEST_DRIVER_REMOVE
-	bool "Test driver remove calls during probe"
+	bool "Test driver remove calls during probe (UNSTABLE)"
 	depends on DEBUG_KERNEL
 	help
 	  Say Y here if you want the Driver core to test driver remove functions
 	  by calling probe, remove, probe. This tests the remove path without
 	  having to unbind the driver or unload the driver module.
 
-	  If you are unsure about this, say N here.
+	  This option is expected to find errors and may render your system
+	  unusable. You should say N here unless you are explicitly looking to
+	  test this functionality.
 
 config SYS_HYPERVISOR
 	bool
-- 
2.7.4

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning Laura Abbott <labbott@redhat.com> - 2016-10-07 02:00 +0200
  Re: CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-10-07 06:10 +0200
    Re: CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning Laura Abbott <labbott@redhat.com> - 2016-10-07 17:50 +0200
  Re: CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning Rob Herring <robh@kernel.org> - 2016-10-07 06:10 +0200
    Re: CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning Laura Abbott <labbott@redhat.com> - 2016-10-07 17:50 +0200
  [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger Laura Abbott <labbott@redhat.com> - 2016-10-07 18:10 +0200

csiph-web