Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1497313

[PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger

From Laura Abbott <labbott@redhat.com>
Newsgroups linux.kernel
Subject [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger
Date 2016-10-07 18:10 +0200
Message-ID <spFSF-2Rh-29@gated-at.bofh.it> (permalink)
References <spqK3-85w-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


The current state of driver removal is not great.
CONFIG_DEBUG_TEST_DRIVER_REMOVE finds lots of errors. The help text
currently undersells exactly how many errors this option will find. Add
a bit more description to indicate this option shouldn't be turned on
unless you actually want to debug driver removal. The text can be
changed later when more drivers are fixed up.

Signed-off-by: Laura Abbott <labbott@redhat.com>
---
 drivers/base/Kconfig | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index fdf44ca..d02e7c0 100644
--- a/drivers/base/Kconfig
+++ b/drivers/base/Kconfig
@@ -213,14 +213,16 @@ config DEBUG_DEVRES
 	  If you are unsure about this, Say N here.
 
 config DEBUG_TEST_DRIVER_REMOVE
-	bool "Test driver remove calls during probe"
+	bool "Test driver remove calls during probe (UNSTABLE)"
 	depends on DEBUG_KERNEL
 	help
 	  Say Y here if you want the Driver core to test driver remove functions
 	  by calling probe, remove, probe. This tests the remove path without
 	  having to unbind the driver or unload the driver module.
 
-	  If you are unsure about this, say N here.
+	  This option is expected to find errors and may render your system
+	  unusable. You should say N here unless you are explicitly looking to
+	  test this functionality.
 
 config SYS_HYPERVISOR
 	bool
-- 
2.7.4

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning Laura Abbott <labbott@redhat.com> - 2016-10-07 02:00 +0200
  Re: CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-10-07 06:10 +0200
    Re: CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning Laura Abbott <labbott@redhat.com> - 2016-10-07 17:50 +0200
  Re: CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning Rob Herring <robh@kernel.org> - 2016-10-07 06:10 +0200
    Re: CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning Laura Abbott <labbott@redhat.com> - 2016-10-07 17:50 +0200
  [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger Laura Abbott <labbott@redhat.com> - 2016-10-07 18:10 +0200

csiph-web