Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1496947 > unrolled thread
| Started by | Laura Abbott <labbott@redhat.com> |
|---|---|
| First post | 2016-10-07 02:00 +0200 |
| Last post | 2016-10-07 18:10 +0200 |
| Articles | 6 — 3 participants |
Back to article view | Back to linux.kernel
CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning Laura Abbott <labbott@redhat.com> - 2016-10-07 02:00 +0200
Re: CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-10-07 06:10 +0200
Re: CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning Laura Abbott <labbott@redhat.com> - 2016-10-07 17:50 +0200
Re: CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning Rob Herring <robh@kernel.org> - 2016-10-07 06:10 +0200
Re: CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning Laura Abbott <labbott@redhat.com> - 2016-10-07 17:50 +0200
[PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger Laura Abbott <labbott@redhat.com> - 2016-10-07 18:10 +0200
| From | Laura Abbott <labbott@redhat.com> |
|---|---|
| Date | 2016-10-07 02:00 +0200 |
| Subject | CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning |
| Message-ID | <spqK3-85w-15@gated-at.bofh.it> |
On a whim, I decided to turn on CONFIG_DEBUG_TEST_DRIVER_REMOVE on Fedora rawhide since it sounded harmless enough. It spewed warnings and panicked some systems. Clearly it's doing its job well of finding drivers that can't handle remove properly and I underestimated it. I was expecting to maybe find a driver or two. Can we get stronger Kconfig text indicating that this shouldn't be turned on lightly? I'll be turning the option off in Fedora but sending out reports from what was found. Thanks, Laura
[toc] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-10-07 06:10 +0200 |
| Message-ID | <spuDU-2QL-5@gated-at.bofh.it> |
| In reply to | #1496947 |
On Thu, Oct 06, 2016 at 04:53:20PM -0700, Laura Abbott wrote: > On a whim, I decided to turn on CONFIG_DEBUG_TEST_DRIVER_REMOVE on > Fedora rawhide since it sounded harmless enough. It spewed warnings > and panicked some systems. Clearly it's doing its job > well of finding drivers that can't handle remove properly and I > underestimated it. Yes, we knew it was going to find bugs, you were brave :) > I was expecting to maybe find a driver or two. > Can we get stronger Kconfig text indicating that this shouldn't be > turned on lightly? I'll be turning the option off in Fedora but sending > out reports from what was found. Care to send a patch with the wording change you would have found better to warn yourself not to do this? thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Laura Abbott <labbott@redhat.com> |
|---|---|
| Date | 2016-10-07 17:50 +0200 |
| Message-ID | <spFzk-2tG-27@gated-at.bofh.it> |
| In reply to | #1496980 |
On 10/06/2016 08:56 PM, Greg Kroah-Hartman wrote: > On Thu, Oct 06, 2016 at 04:53:20PM -0700, Laura Abbott wrote: >> On a whim, I decided to turn on CONFIG_DEBUG_TEST_DRIVER_REMOVE on >> Fedora rawhide since it sounded harmless enough. It spewed warnings >> and panicked some systems. Clearly it's doing its job >> well of finding drivers that can't handle remove properly and I >> underestimated it. > > Yes, we knew it was going to find bugs, you were brave :) > Sure, let's go with brave. That makes me sound good ;) >> I was expecting to maybe find a driver or two. >> Can we get stronger Kconfig text indicating that this shouldn't be >> turned on lightly? I'll be turning the option off in Fedora but sending >> out reports from what was found. > > Care to send a patch with the wording change you would have found better > to warn yourself not to do this? > Sure. > thanks, > > greg k-h > Thanks, Laura
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2016-10-07 06:10 +0200 |
| Message-ID | <spuDU-2QL-7@gated-at.bofh.it> |
| In reply to | #1496947 |
On Thu, Oct 6, 2016 at 6:53 PM, Laura Abbott <labbott@redhat.com> wrote: > On a whim, I decided to turn on CONFIG_DEBUG_TEST_DRIVER_REMOVE on > Fedora rawhide since it sounded harmless enough. It spewed warnings > and panicked some systems. Clearly it's doing its job > well of finding drivers that can't handle remove properly and I > underestimated it. I was expecting to maybe find a driver or two. > Can we get stronger Kconfig text indicating that this shouldn't be > turned on lightly? I'll be turning the option off in Fedora but sending > out reports from what was found. It hides behind CONFIG_DEBUG already. Is there a better option that distros won't turn on? Rob
[toc] | [prev] | [next] | [standalone]
| From | Laura Abbott <labbott@redhat.com> |
|---|---|
| Date | 2016-10-07 17:50 +0200 |
| Message-ID | <spFzk-2tG-37@gated-at.bofh.it> |
| In reply to | #1496985 |
On 10/06/2016 09:06 PM, Rob Herring wrote: > On Thu, Oct 6, 2016 at 6:53 PM, Laura Abbott <labbott@redhat.com> wrote: >> On a whim, I decided to turn on CONFIG_DEBUG_TEST_DRIVER_REMOVE on >> Fedora rawhide since it sounded harmless enough. It spewed warnings >> and panicked some systems. Clearly it's doing its job >> well of finding drivers that can't handle remove properly and I >> underestimated it. I was expecting to maybe find a driver or two. >> Can we get stronger Kconfig text indicating that this shouldn't be >> turned on lightly? I'll be turning the option off in Fedora but sending >> out reports from what was found. > > It hides behind CONFIG_DEBUG already. Is there a better option that > distros won't turn on? For Fedora rawhide, we tend to turn on debug options that don't have a significant performance impact to hopefully make the kernel better for Fedora stable releases. Apart from a more explicit Kconfig text, you could hide it behind CONFIG_EXPERT which Fedora doesn't turn on and is more of a hint that this should only be used in specific circumstances. > > Rob > Thanks, Laura
[toc] | [prev] | [next] | [standalone]
| From | Laura Abbott <labbott@redhat.com> |
|---|---|
| Date | 2016-10-07 18:10 +0200 |
| Subject | [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger |
| Message-ID | <spFSF-2Rh-29@gated-at.bofh.it> |
| In reply to | #1496947 |
The current state of driver removal is not great. CONFIG_DEBUG_TEST_DRIVER_REMOVE finds lots of errors. The help text currently undersells exactly how many errors this option will find. Add a bit more description to indicate this option shouldn't be turned on unless you actually want to debug driver removal. The text can be changed later when more drivers are fixed up. Signed-off-by: Laura Abbott <labbott@redhat.com> --- drivers/base/Kconfig | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig index fdf44ca..d02e7c0 100644 --- a/drivers/base/Kconfig +++ b/drivers/base/Kconfig @@ -213,14 +213,16 @@ config DEBUG_DEVRES If you are unsure about this, Say N here. config DEBUG_TEST_DRIVER_REMOVE - bool "Test driver remove calls during probe" + bool "Test driver remove calls during probe (UNSTABLE)" depends on DEBUG_KERNEL help Say Y here if you want the Driver core to test driver remove functions by calling probe, remove, probe. This tests the remove path without having to unbind the driver or unload the driver module. - If you are unsure about this, say N here. + This option is expected to find errors and may render your system + unusable. You should say N here unless you are explicitly looking to + test this functionality. config SYS_HYPERVISOR bool -- 2.7.4
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web