Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1494881
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] pinctrl: qcom: fix masking of pinmux functions |
| Date | 2016-10-03 15:40 +0200 |
| Message-ID | <sobDj-5y2-5@gated-at.bofh.it> (permalink) |
| References | <sgvSy-1oS-21@gated-at.bofh.it> <slxK1-kB-23@gated-at.bofh.it> <slGtX-5EQ-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Sep 26, 2016 at 5:52 PM, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> On Sun 25 Sep 23:36 PDT 2016, Stephen Boyd wrote:
>
>> On Mon, Sep 12, 2016 at 2:36 AM, John Crispin <john@phrozen.org> wrote:
>> > The following commit introduced a regression by not properly masking the
>> > calculated value.
>> >
>> > commit 47a01ee9a6c39fe1 ("pinctrl: qcom: Clear all function selection bits")
>
> Please use the format: Fixes: %h (\"%s\")
>
>> >
>> > Signed-off-by: John Crispin <john@phrozen.org>
>>
>> Now I'm confused how it ever worked.... but agreed, the code looks wrong.
>
> I agree, we should have seen some issues based on this, I presume we
> where "lucky".
>
>>
>> Reviewed-by: Stephen Boyd <stephen.boyd@linaro.org>
>>
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> @Linus, the corrected patch appeared in v4.8-rc1, would you mind
> including this in a pull for v4.8?
I would have, had I been more attentive. And you even told me in person to
look at this :/ sorry.
Now I have the problem that I don't have the original patch in my inbox
at all: it might have been sent to some qcom-specific mailing list?
John: can you include the ACKs and resend with me on the To: line?
Yours,
Linus Walleij
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] pinctrl: qcom: fix masking of pinmux functions Stephen Boyd <stephen.boyd@linaro.org> - 2016-09-26 08:40 +0200
Re: [PATCH] pinctrl: qcom: fix masking of pinmux functions Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-09-26 18:00 +0200
Re: [PATCH] pinctrl: qcom: fix masking of pinmux functions Linus Walleij <linus.walleij@linaro.org> - 2016-10-03 15:40 +0200
Re: [PATCH] pinctrl: qcom: fix masking of pinmux functions John Crispin <john@phrozen.org> - 2016-10-03 16:30 +0200
Re: [PATCH] pinctrl: qcom: fix masking of pinmux functions Linus Walleij <linus.walleij@linaro.org> - 2016-10-04 00:40 +0200
Re: [PATCH] pinctrl: qcom: fix masking of pinmux functions Stephen Boyd <stephen.boyd@linaro.org> - 2016-10-03 23:00 +0200
csiph-web