Re: [PATCH] rxrpc: split up rxrpc_send_call_packet()

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] rxrpc: split up rxrpc_send_call_packet()
Date	2016-10-01 11:20 +0200
Message-ID	<snoCF-6hV-147@gated-at.bofh.it> (permalink)
References	<snjtf-2OO-1@gated-at.bofh.it> <snfzk-h2-3@gated-at.bofh.it> <sn8Hw-4bK-27@gated-at.bofh.it> <snfSF-or-3@gated-at.bofh.it> <snjtf-2OO-1@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Arnd Bergmann <arnd@arndb.de> wrote:

> Yes, good idea. We could probably share the part of the two functions that
> sets the contents of the msg and pkt variables by moving it into a third
> function, but I'm not sure if that actually improves readability or just
> reduces the number of lines.

And the ACK-sending function is about to get a bit more complex :-(

David

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] rxrpc: split up rxrpc_send_call_packet() Arnd Bergmann <arnd@arndb.de> - 2016-09-30 18:20 +0200
  Re: [PATCH] rxrpc: split up rxrpc_send_call_packet() David Howells <dhowells@redhat.com> - 2016-10-01 01:40 +0200
    Re: [PATCH] rxrpc: split up rxrpc_send_call_packet() David Howells <dhowells@redhat.com> - 2016-10-01 02:00 +0200
      Re: [PATCH] rxrpc: split up rxrpc_send_call_packet() Arnd Bergmann <arnd@arndb.de> - 2016-10-01 05:50 +0200
        Re: [PATCH] rxrpc: split up rxrpc_send_call_packet() David Howells <dhowells@redhat.com> - 2016-10-01 11:20 +0200

csiph-web