Re: [PATCH] rxrpc: split up rxrpc_send_call_packet()

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] rxrpc: split up rxrpc_send_call_packet()
Date	2016-10-01 01:40 +0200
Message-ID	<snfzk-h2-3@gated-at.bofh.it> (permalink)
References	<sn8Hw-4bK-27@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Arnd Bergmann <arnd@arndb.de> wrote:

> A number of reworks went into rxrpc_send_call_packet() recently, which
> introduced another warning when built with -Wmaybe-uninitialized:
> 
> In file included from ../net/rxrpc/output.c:20:0:
> net/rxrpc/output.c: In function 'rxrpc_send_call_packet':
> net/rxrpc/ar-internal.h:1187:27: error: 'top' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> net/rxrpc/output.c:103:24: note: 'top' was declared here
> net/rxrpc/output.c:225:25: error: 'hard_ack' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> This is a false positive, but it's also an indication that the function is
> getting complex enough that the compiler cannot figure out what it does.
> 
> This splits out a rxrpc_send_ack_packet() function for one part of
> it, making it more understandable by both humans and the compiler
> and avoiding the warning.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Unfortunately, this is a larger rework that I was hoping for, and
> I have only build tested it, so please review carefully, or just
> discard it and treat it as feedback to the original patch.

I think I'd rather cleanly split it into two transmission functions.  I'll do
that.

Thanks,
David

Thread

[PATCH] rxrpc: split up rxrpc_send_call_packet() Arnd Bergmann <arnd@arndb.de> - 2016-09-30 18:20 +0200
  Re: [PATCH] rxrpc: split up rxrpc_send_call_packet() David Howells <dhowells@redhat.com> - 2016-10-01 01:40 +0200
    Re: [PATCH] rxrpc: split up rxrpc_send_call_packet() David Howells <dhowells@redhat.com> - 2016-10-01 02:00 +0200
      Re: [PATCH] rxrpc: split up rxrpc_send_call_packet() Arnd Bergmann <arnd@arndb.de> - 2016-10-01 05:50 +0200
        Re: [PATCH] rxrpc: split up rxrpc_send_call_packet() David Howells <dhowells@redhat.com> - 2016-10-01 11:20 +0200

csiph-web