Re: [PATCH v5 2/2] usb: chipidea: imx: Add binding to disable USB 60Mhz clock

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 2/2] usb: chipidea: imx: Add binding to disable USB 60Mhz clock
Date	Mon, 26 Sep 2016 11:00:01 +0200
Message-ID	<slzVv-1EX-29@gated-at.bofh.it> (permalink)
References	<sjLHs-74R-19@gated-at.bofh.it> <sjLHs-74R-31@gated-at.bofh.it> <slziN-1rJ-7@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.2.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	Peter.Chen@nxp.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 26 Sep 2016 10:54:52 +0200
X-Original-Message-ID	<bc80fe0a-8a9f-a597-8f8b-e7875302b337@collabora.co.uk>
X-Original-References	<1474448827-8354-1-git-send-email-fabien.lahoudere@collabora.co.uk> <1474448827-8354-3-git-send-email-fabien.lahoudere@collabora.co.uk> <20160926081841.7jmvdto2ht23rdw6@pengutronix.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1491163

Show key headers only | View raw

Hi,

On 26/09/16 10:18, Sascha Hauer wrote:
> On Wed, Sep 21, 2016 at 11:07:07AM +0200, Fabien Lahoudere wrote:
>> This binding allow to disable the internal 60Mhz clock for USB host2 or
>> host3.
>>
>> Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>
>> ---
>>  Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt |  1 +
>>  drivers/usb/chipidea/ci_hdrc_imx.c                     |  2 ++
>>  drivers/usb/chipidea/ci_hdrc_imx.h                     |  1 +
>>  drivers/usb/chipidea/usbmisc_imx.c                     | 13 +++++++++++++
>>  4 files changed, 17 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
>> index 0e03344..f83da66 100644
>> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
>> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
>> @@ -84,6 +84,7 @@ i.mx specific properties
>>  - over-current-active-high: over current signal polarity is high active,
>>    typically over current signal polarity is low active.
>>  - external-vbus-divider: enables off-chip resistor divider for Vbus
>> +- disable-int60ck: disable internal 60MHz clock for usb host2 or host3 on imx53
>
> Why do we need a binding for this? I would assume the driver should know
> whether this clock is in use or not. If it doesn't that's a problem we
> should solve.
>

Yes you are right because we can disable this clock for OTG and with 
ULPI PHY. I think that it will be better to have a dt binding but if it 
is useless I can remove it and disable clock when ULPI mode is enabled.

> Sascha
>

Fabien

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 2/2] usb: chipidea: imx: Add binding to disable USB  60Mhz clock Sascha Hauer <s.hauer@pengutronix.de> - 2016-09-26 10:20 +0200
  Re: [PATCH v5 2/2] usb: chipidea: imx: Add binding to disable USB  60Mhz clock Fabien Lahoudere <fabien.lahoudere@collabora.co.uk> - 2016-09-26 11:00 +0200

csiph-web