Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1491494

Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style

Show all headers | View raw

On 09/26/2016 06:20 AM, Gonçalo Salazar wrote:
> 2016-09-26 1:53 GMT+01:00 Larry Finger <Larry.Finger@lwfinger.net>:
>> On 09/25/2016 06:00 PM, Gonçalo Salazar wrote:
>>>
>>> Fixed a block comment indentation in the rtl8712 usb_intf.c file.
>>> Made this as a first commit.
>>> Resubmitted with updated subject.
>>>
>>> Please let me know of any feedback you have.
>>
>>
>> I missed this last time, but everything above the --- line goes into the
>> permanent record. Are you sure you want all this to be there? Any chatty
>> remarks and any description of what changed in subsequent submissions should
>> be below the ---. The maintainer will see them, but they are stripped before
>> they get merged into the repo.
>>
>> Larry
>
> Made a mistake that should not be in the permanent record...
> Should I resubmit the patch? or are you able to strip it from the submission?

I am not the one that applies the patches; however, it would be unreasonable to 
expect the maintainer to edit any patch. You need to submit V3.

Larry

>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style Gonçalo Salazar <glbsalazar@gmail.com> - 2016-09-26 01:10 +0200
  Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment  coding style Larry Finger <Larry.Finger@lwfinger.net> - 2016-09-26 03:00 +0200
    Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment  coding style Gonçalo Salazar <glbsalazar@gmail.com> - 2016-09-26 13:30 +0200
      Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment  coding style Larry Finger <Larry.Finger@lwfinger.net> - 2016-09-26 20:20 +0200

csiph-web