Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1490993 > unrolled thread
| Started by | Gonçalo Salazar <glbsalazar@gmail.com> |
|---|---|
| First post | 2016-09-26 01:10 +0200 |
| Last post | 2016-09-26 20:20 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style Gonçalo Salazar <glbsalazar@gmail.com> - 2016-09-26 01:10 +0200
Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style Larry Finger <Larry.Finger@lwfinger.net> - 2016-09-26 03:00 +0200
Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style Gonçalo Salazar <glbsalazar@gmail.com> - 2016-09-26 13:30 +0200
Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style Larry Finger <Larry.Finger@lwfinger.net> - 2016-09-26 20:20 +0200
| From | Gonçalo Salazar <glbsalazar@gmail.com> |
|---|---|
| Date | 2016-09-26 01:10 +0200 |
| Subject | [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style |
| Message-ID | <slqIx-4s2-3@gated-at.bofh.it> |
Fixed a block comment indentation in the rtl8712 usb_intf.c file.
Made this as a first commit.
Resubmitted with updated subject.
Please let me know of any feedback you have.
Thanks,
Gonçalo Salazar
Signed-off-by: Gonçalo Salazar <glbsalazar@gmail.com>
---
drivers/staging/rtl8712/usb_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
index 3fc65b2..897d462 100644
--- a/drivers/staging/rtl8712/usb_intf.c
+++ b/drivers/staging/rtl8712/usb_intf.c
@@ -369,7 +369,7 @@ static const struct device_type wlan_type = {
*
* notes: drv_init() is called when the bus driver has located a card for us
* to support. We accept the new device by returning 0.
-*/
+ */
static int r871xu_drv_init(struct usb_interface *pusb_intf,
const struct usb_device_id *pdid)
{
--
2.7.4
[toc] | [next] | [standalone]
| From | Larry Finger <Larry.Finger@lwfinger.net> |
|---|---|
| Date | 2016-09-26 03:00 +0200 |
| Subject | Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style |
| Message-ID | <slsqZ-5fe-3@gated-at.bofh.it> |
| In reply to | #1490993 |
On 09/25/2016 06:00 PM, Gonçalo Salazar wrote:
> Fixed a block comment indentation in the rtl8712 usb_intf.c file.
> Made this as a first commit.
> Resubmitted with updated subject.
>
> Please let me know of any feedback you have.
I missed this last time, but everything above the --- line goes into the
permanent record. Are you sure you want all this to be there? Any chatty remarks
and any description of what changed in subsequent submissions should be below
the ---. The maintainer will see them, but they are stripped before they get
merged into the repo.
Larry
>
> Thanks,
> Gonçalo Salazar
>
> Signed-off-by: Gonçalo Salazar <glbsalazar@gmail.com>
> ---
> drivers/staging/rtl8712/usb_intf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
> index 3fc65b2..897d462 100644
> --- a/drivers/staging/rtl8712/usb_intf.c
> +++ b/drivers/staging/rtl8712/usb_intf.c
> @@ -369,7 +369,7 @@ static const struct device_type wlan_type = {
> *
> * notes: drv_init() is called when the bus driver has located a card for us
> * to support. We accept the new device by returning 0.
> -*/
> + */
> static int r871xu_drv_init(struct usb_interface *pusb_intf,
> const struct usb_device_id *pdid)
> {
>
[toc] | [prev] | [next] | [standalone]
| From | Gonçalo Salazar <glbsalazar@gmail.com> |
|---|---|
| Date | 2016-09-26 13:30 +0200 |
| Subject | Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style |
| Message-ID | <slCgF-3eh-11@gated-at.bofh.it> |
| In reply to | #1491030 |
2016-09-26 1:53 GMT+01:00 Larry Finger <Larry.Finger@lwfinger.net>:
> On 09/25/2016 06:00 PM, Gonçalo Salazar wrote:
>>
>> Fixed a block comment indentation in the rtl8712 usb_intf.c file.
>> Made this as a first commit.
>> Resubmitted with updated subject.
>>
>> Please let me know of any feedback you have.
>
>
> I missed this last time, but everything above the --- line goes into the
> permanent record. Are you sure you want all this to be there? Any chatty
> remarks and any description of what changed in subsequent submissions should
> be below the ---. The maintainer will see them, but they are stripped before
> they get merged into the repo.
>
> Larry
Made a mistake that should not be in the permanent record...
Should I resubmit the patch? or are you able to strip it from the submission?
Gonçalo
>
>
>>
>> Thanks,
>> Gonçalo Salazar
>>
>> Signed-off-by: Gonçalo Salazar <glbsalazar@gmail.com>
>> ---
>> drivers/staging/rtl8712/usb_intf.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8712/usb_intf.c
>> b/drivers/staging/rtl8712/usb_intf.c
>> index 3fc65b2..897d462 100644
>> --- a/drivers/staging/rtl8712/usb_intf.c
>> +++ b/drivers/staging/rtl8712/usb_intf.c
>> @@ -369,7 +369,7 @@ static const struct device_type wlan_type = {
>> *
>> * notes: drv_init() is called when the bus driver has located a card for
>> us
>> * to support. We accept the new device by returning 0.
>> -*/
>> + */
>> static int r871xu_drv_init(struct usb_interface *pusb_intf,
>> const struct usb_device_id *pdid)
>> {
>>
>
[toc] | [prev] | [next] | [standalone]
| From | Larry Finger <Larry.Finger@lwfinger.net> |
|---|---|
| Date | 2016-09-26 20:20 +0200 |
| Subject | Re: [PATCH V2] staging: rtl8172: usb_intf.c: Fixed block comment coding style |
| Message-ID | <slIFr-7fo-13@gated-at.bofh.it> |
| In reply to | #1491229 |
On 09/26/2016 06:20 AM, Gonçalo Salazar wrote: > 2016-09-26 1:53 GMT+01:00 Larry Finger <Larry.Finger@lwfinger.net>: >> On 09/25/2016 06:00 PM, Gonçalo Salazar wrote: >>> >>> Fixed a block comment indentation in the rtl8712 usb_intf.c file. >>> Made this as a first commit. >>> Resubmitted with updated subject. >>> >>> Please let me know of any feedback you have. >> >> >> I missed this last time, but everything above the --- line goes into the >> permanent record. Are you sure you want all this to be there? Any chatty >> remarks and any description of what changed in subsequent submissions should >> be below the ---. The maintainer will see them, but they are stripped before >> they get merged into the repo. >> >> Larry > > Made a mistake that should not be in the permanent record... > Should I resubmit the patch? or are you able to strip it from the submission? I am not the one that applies the patches; however, it would be unreasonable to expect the maintainer to edit any patch. You need to submit V3. Larry >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web