Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1491493

[PATCH trival 1/2] bpf: clean up put_cpu_var usage

From Shaohua Li <shli@fb.com>
Newsgroups linux.kernel
Subject [PATCH trival 1/2] bpf: clean up put_cpu_var usage
Date 2016-09-26 20:20 +0200
Message-ID <slIFr-7fo-9@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


put_cpu_var takes the percpu data, not the data returned from
get_cpu_var.

This doesn't change the behavior.

Cc: Tejun Heo <tj@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Shaohua Li <shli@fb.com>
---
 kernel/bpf/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c
index 03fd23d..b73913b 100644
--- a/kernel/bpf/core.c
+++ b/kernel/bpf/core.c
@@ -1031,7 +1031,7 @@ u64 bpf_user_rnd_u32(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5)
 
 	state = &get_cpu_var(bpf_user_rnd_state);
 	res = prandom_u32_state(state);
-	put_cpu_var(state);
+	put_cpu_var(bpf_user_rnd_state);
 
 	return res;
 }
-- 
2.9.3

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH trival 1/2] bpf: clean up put_cpu_var usage Shaohua Li <shli@fb.com> - 2016-09-26 20:20 +0200
  [PATCH trival 2/2] lib: clean up put_cpu_var usage Shaohua Li <shli@fb.com> - 2016-09-26 20:20 +0200
  Re: [PATCH trival 1/2] bpf: clean up put_cpu_var usage Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-09-27 02:00 +0200
    Re: [PATCH trival 1/2] bpf: clean up put_cpu_var usage Daniel Borkmann <daniel@iogearbox.net> - 2016-09-27 13:00 +0200

csiph-web