Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()

From	Emil Velikov <emil.l.velikov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()
Date	2016-09-23 15:40 +0200
Message-ID	<skyRQ-4e3-19@gated-at.bofh.it> (permalink)
References	(3 earlier) <skc4W-6RE-23@gated-at.bofh.it> <skiN3-2zX-7@gated-at.bofh.it> <skt5L-GK-1@gated-at.bofh.it> <sktyN-Qs-1@gated-at.bofh.it> <skuuR-1sk-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 23 September 2016 at 09:50, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
>> Markus, please contact the list in advance in future before posting a bunch
>> of patches that don't fix any problems.
>
> I am trying to improve various open issues also in Linux source files.
>
That the fact that you see issues (in these particular cases) while
others do not indicates that the commit summary could be explained
better.

A good commit summary should provide enough information to do that and
make people _want_ the patch. From my limited experience through your
patches (just skimmed a few) you seems to be describing what the patch
does as opposed to why it does it and why should one find it
interesting/wanted.

You might want to read through the following [1] [2] and many others
that exist out there.

-Emil

[1] http://chris.beams.io/posts/git-commit/
[2] http://who-t.blogspot.fi/2009/12/on-commit-messages.html

Thread

[PATCH 0/4] GPU-DRM-QXL: Fine-tuning for three function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 08:30 +0200
  [PATCH 2/4] GPU-DRM-QXL: Move three assignments in qxl_device_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 08:30 +0200
    Re: [PATCH 2/4] GPU-DRM-QXL: Move three assignments in  qxl_device_init() Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-22 12:20 +0200
      Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 15:20 +0200
        Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() Gerd Hoffmann <kraxel@redhat.com> - 2016-09-22 17:50 +0200
          Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 19:20 +0200
            Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() Gerd Hoffmann <kraxel@redhat.com> - 2016-09-22 22:30 +0200
        Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-22 22:30 +0200
          Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() Sean Paul <seanpaul@chromium.org> - 2016-09-23 09:30 +0200
            Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() Dave Airlie <airlied@gmail.com> - 2016-09-23 10:00 +0200
              Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-23 11:00 +0200
                Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() Emil Velikov <emil.l.velikov@gmail.com> - 2016-09-23 15:40 +0200
                Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-23 16:30 +0200
            Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-23 10:50 +0200
          Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-23 10:40 +0200
  [PATCH 3/4] GPU-DRM-QXL: Improve a size determination in  qxl_driver_load() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 08:30 +0200
  [PATCH 4/4] GPU-DRM-QXL: Adjust checks for null pointers in three  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 08:30 +0200

csiph-web