Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()

From	Gerd Hoffmann <kraxel@redhat.com>
Newsgroups	linux.kernel
Subject	Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()
Date	2016-09-22 22:30 +0200
Message-ID	<skiN3-2zX-19@gated-at.bofh.it> (permalink)
References	(1 earlier) <sk5G9-2NH-5@gated-at.bofh.it> <sk9gJ-51T-3@gated-at.bofh.it> <skc4W-6RE-23@gated-at.bofh.it> <skeq7-8dN-71@gated-at.bofh.it> <skfPc-Kt-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Do, 2016-09-22 at 19:16 +0200, SF Markus Elfring wrote:
> > For starters make sure the patches land actually on the list.
> 
> How do you think about to take another look at this update suggestion
> also by the usual archive interfaces?
> 
> * https://patchwork.kernel.org/patch/9344521/
> 
> * https://lkml.kernel.org/r/<f7eb26ad-39be-2918-627b-5f4981d07808@users.sourceforge.net>

I fail to see the point in this change.  On init failure qdev will be
released anyway, and whenever the fields are initialized or not when
kfree() is called doesn't matter at all.

> > Only the cover letter arrived here.
> 
> Would you like to clarify any more technical difficulties around
> the desired message exchange?

Hmm, not sure what happened.  According to the kernel.org link the patch
has been sent to dri-devel (where I'm subscribed), but the patch never
landed in by mailbox for some reason.

cheers,
  Gerd

Thread

[PATCH 0/4] GPU-DRM-QXL: Fine-tuning for three function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 08:30 +0200
  [PATCH 2/4] GPU-DRM-QXL: Move three assignments in qxl_device_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 08:30 +0200
    Re: [PATCH 2/4] GPU-DRM-QXL: Move three assignments in  qxl_device_init() Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-22 12:20 +0200
      Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 15:20 +0200
        Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() Gerd Hoffmann <kraxel@redhat.com> - 2016-09-22 17:50 +0200
          Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 19:20 +0200
            Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() Gerd Hoffmann <kraxel@redhat.com> - 2016-09-22 22:30 +0200
        Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-22 22:30 +0200
          Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() Sean Paul <seanpaul@chromium.org> - 2016-09-23 09:30 +0200
            Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() Dave Airlie <airlied@gmail.com> - 2016-09-23 10:00 +0200
              Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-23 11:00 +0200
                Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() Emil Velikov <emil.l.velikov@gmail.com> - 2016-09-23 15:40 +0200
                Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-23 16:30 +0200
            Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-23 10:50 +0200
          Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-23 10:40 +0200
  [PATCH 3/4] GPU-DRM-QXL: Improve a size determination in  qxl_driver_load() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 08:30 +0200
  [PATCH 4/4] GPU-DRM-QXL: Adjust checks for null pointers in three  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-22 08:30 +0200

csiph-web