Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1489864

Re: [PATCH] mm: warn about allocations which stall for too long

Show all headers | View raw

On Friday, September 23, 2016 4:32 PM, Michal Hocko wrote
> On Fri 23-09-16 16:29:36, Hillf Danton wrote:
> [...]
> > > @@ -3659,6 +3661,15 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order,
> > >  	else
> > >  		no_progress_loops++;
> > >
> > > +	/* Make sure we know about allocations which stall for too long */
> > > +	if (!(gfp_mask & __GFP_NOWARN) && time_after(jiffies, alloc_start + stall_timeout)) {
> > > +		pr_warn("%s: page alloction stalls for %ums: order:%u mode:%#x(%pGg)\n",
> > > +				current->comm, jiffies_to_msecs(jiffies-alloc_start),
> >
> > Better if pid is also printed.
> 
> I've tried to be consistent with warn_alloc_failed and that doesn't
> print pid either. Maybe both of them should. Dunno
> 
With pid imho we can distinguish two tasks with same name in a simpler way. 

> > > +				order, gfp_mask, &gfp_mask);
> > > +		stall_timeout += 10 * HZ;
> >
> > Alternatively	 alloc_start = jiffies;
> 
> Then we would lose the cumulative time in the output which is imho
> helpful because you cannot tell whether the new warning is a new request
> or the old one still looping.
> 
Fair.

thanks
Hillf

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-23 10:20 +0200
  Re: [PATCH] mm: warn about allocations which stall for too long "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-09-23 10:40 +0200
    Re: [PATCH] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-23 10:40 +0200
      Re: [PATCH] mm: warn about allocations which stall for too long "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-09-23 11:00 +0200
        Re: [PATCH] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-23 11:20 +0200
  Re: [PATCH] mm: warn about allocations which stall for too long Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-09-23 16:40 +0200
    Re: [PATCH] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-23 17:10 +0200
      Re: [PATCH] mm: warn about allocations which stall for too long Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-09-24 05:10 +0200
        Re: [PATCH] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-26 10:20 +0200
          Re: [PATCH] mm: warn about allocations which stall for too long Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-09-27 15:00 +0200
            Re: [PATCH] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-29 10:50 +0200
  Re: [PATCH] mm: warn about allocations which stall for too long Dave Hansen <dave.hansen@intel.com> - 2016-09-23 19:40 +0200
    Re: [PATCH] mm: warn about allocations which stall for too long Balbir Singh <bsingharora@gmail.com> - 2016-09-24 15:20 +0200
      Re: [PATCH] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-26 10:20 +0200
    Re: [PATCH] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-26 10:20 +0200
  [PATCH 2/2] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-29 10:50 +0200
    Re: [PATCH 2/2] mm: warn about allocations which stall for too long Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-09-29 11:10 +0200
      Re: [PATCH 2/2] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-29 11:20 +0200
  [PATCH 1/2] mm: consolidate warn_alloc_failed users Michal Hocko <mhocko@kernel.org> - 2016-09-29 10:50 +0200
    Re: [PATCH 1/2] mm: consolidate warn_alloc_failed users Vlastimil Babka <vbabka@suse.cz> - 2016-09-29 11:30 +0200
  [PATCH 0/2] warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-29 10:50 +0200

csiph-web