Re: [PATCH 1/2] mm: consolidate warn_alloc_failed users

From	Vlastimil Babka <vbabka@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] mm: consolidate warn_alloc_failed users
Date	2016-09-29 11:30 +0200
Message-ID	<smFPc-2bi-15@gated-at.bofh.it> (permalink)
References	<sktS9-1fi-5@gated-at.bofh.it> <smFct-1IL-7@gated-at.bofh.it> <smFcu-1IL-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/29/2016 10:44 AM, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>
>
> warn_alloc_failed is currently used from the page and vmalloc
> allocators. This is a good reuse of the code except that vmalloc would
> appreciate a slightly different warning message. This is already handled
> by the fmt parameter except that
>
> "%s: page allocation failure: order:%u, mode:%#x(%pGg)"
>
> is printed anyway. This might be quite misleading because it might be
> a vmalloc failure which leads to the warning while the page allocator is
> not the culprit here. Fix this by always using the fmt string and only
> print the context that makes sense for the particular context (e.g.
> order makes only very little sense for the vmalloc context). Rename
> the function to not miss any user and also because a later patch will
> reuse it also for !failure cases.
>
> Signed-off-by: Michal Hocko <mhocko@suse.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] mm: consolidate warn_alloc_failed users Michal Hocko <mhocko@kernel.org> - 2016-09-29 10:50 +0200
  Re: [PATCH 1/2] mm: consolidate warn_alloc_failed users Vlastimil Babka <vbabka@suse.cz> - 2016-09-29 11:30 +0200

csiph-web