Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1489870
| From | Michal Hocko <mhocko@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mm: warn about allocations which stall for too long |
| Date | 2016-09-23 11:20 +0200 |
| Message-ID | <skuOd-1O5-1@gated-at.bofh.it> (permalink) |
| References | <sktS9-1fi-5@gated-at.bofh.it> <skubv-1lK-15@gated-at.bofh.it> <skubv-1lK-13@gated-at.bofh.it> <skuuR-1sk-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri 23-09-16 16:44:26, Hillf Danton wrote:
> On Friday, September 23, 2016 4:32 PM, Michal Hocko wrote
> > On Fri 23-09-16 16:29:36, Hillf Danton wrote:
> > [...]
> > > > @@ -3659,6 +3661,15 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order,
> > > > else
> > > > no_progress_loops++;
> > > >
> > > > + /* Make sure we know about allocations which stall for too long */
> > > > + if (!(gfp_mask & __GFP_NOWARN) && time_after(jiffies, alloc_start + stall_timeout)) {
> > > > + pr_warn("%s: page alloction stalls for %ums: order:%u mode:%#x(%pGg)\n",
> > > > + current->comm, jiffies_to_msecs(jiffies-alloc_start),
> > >
> > > Better if pid is also printed.
> >
> > I've tried to be consistent with warn_alloc_failed and that doesn't
> > print pid either. Maybe both of them should. Dunno
> >
> With pid imho we can distinguish two tasks with same name in a simpler way.
I've just checked dump_stack and dump_stack_print_info provides that
information already.
--
Michal Hocko
SUSE Labs
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-23 10:20 +0200
Re: [PATCH] mm: warn about allocations which stall for too long "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-09-23 10:40 +0200
Re: [PATCH] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-23 10:40 +0200
Re: [PATCH] mm: warn about allocations which stall for too long "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-09-23 11:00 +0200
Re: [PATCH] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-23 11:20 +0200
Re: [PATCH] mm: warn about allocations which stall for too long Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-09-23 16:40 +0200
Re: [PATCH] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-23 17:10 +0200
Re: [PATCH] mm: warn about allocations which stall for too long Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-09-24 05:10 +0200
Re: [PATCH] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-26 10:20 +0200
Re: [PATCH] mm: warn about allocations which stall for too long Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-09-27 15:00 +0200
Re: [PATCH] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-29 10:50 +0200
Re: [PATCH] mm: warn about allocations which stall for too long Dave Hansen <dave.hansen@intel.com> - 2016-09-23 19:40 +0200
Re: [PATCH] mm: warn about allocations which stall for too long Balbir Singh <bsingharora@gmail.com> - 2016-09-24 15:20 +0200
Re: [PATCH] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-26 10:20 +0200
Re: [PATCH] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-26 10:20 +0200
[PATCH 2/2] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-29 10:50 +0200
Re: [PATCH 2/2] mm: warn about allocations which stall for too long Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-09-29 11:10 +0200
Re: [PATCH 2/2] mm: warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-29 11:20 +0200
[PATCH 1/2] mm: consolidate warn_alloc_failed users Michal Hocko <mhocko@kernel.org> - 2016-09-29 10:50 +0200
Re: [PATCH 1/2] mm: consolidate warn_alloc_failed users Vlastimil Babka <vbabka@suse.cz> - 2016-09-29 11:30 +0200
[PATCH 0/2] warn about allocations which stall for too long Michal Hocko <mhocko@kernel.org> - 2016-09-29 10:50 +0200
csiph-web