Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1489761
| From | tip-bot for Jiri Olsa <tipbot@zytor.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [tip:perf/core] perf evsel: Remove superfluous initialization of weight |
| Date | 2016-09-23 07:30 +0200 |
| Message-ID | <skrdE-7Yp-9@gated-at.bofh.it> (permalink) |
| References | <sj6NY-5YW-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Commit-ID: 82deb8a242cd8aceaf553c9fb731f91dbdc1f9a6
Gitweb: http://git.kernel.org/tip/82deb8a242cd8aceaf553c9fb731f91dbdc1f9a6
Author: Jiri Olsa <jolsa@kernel.org>
AuthorDate: Mon, 19 Sep 2016 15:09:11 +0200
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 21 Sep 2016 12:07:24 -0300
perf evsel: Remove superfluous initialization of weight
Removing superfluous initialization of weight, it's already set to 0 via
memset.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Joe Mario <jmario@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1474290610-23241-3-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/evsel.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 21fd573..f3225a2 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -1728,7 +1728,6 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event,
data->cpu = data->pid = data->tid = -1;
data->stream_id = data->id = data->time = -1ULL;
data->period = evsel->attr.sample_period;
- data->weight = 0;
data->cpumode = event->header.misc & PERF_RECORD_MISC_CPUMODE_MASK;
if (event->header.type != PERF_RECORD_SAMPLE) {
@@ -1935,7 +1934,6 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event,
}
}
- data->weight = 0;
if (type & PERF_SAMPLE_WEIGHT) {
OVERFLOW_CHECK_u64(array);
data->weight = *array;
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCHv3 00/61] perf c2c: Add new tool to analyze cacheline contention on NUMA systems Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 50/61] perf c2c report: Add c2c related stats stdio output Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 20/61] perf c2c report: Add cacheline hists processing Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 46/61] perf c2c report: Add main browser Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 51/61] perf c2c report: Allow to report callchains Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 22/61] perf c2c report: Add header macros Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 60/61] perf c2c: Add man page and credits Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 61/61] perf tools: Fix width computation for srcline sort entry Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
Re: [PATCH 61/61] perf tools: Fix width computation for srcline sort entry Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-19 16:40 +0200
Re: [PATCH 61/61] perf tools: Fix width computation for srcline sort entry Jiri Olsa <jolsa@redhat.com> - 2016-09-19 16:50 +0200
Re: [PATCH 61/61] perf tools: Fix width computation for srcline sort entry Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-19 17:00 +0200
[tip:perf/core] perf hists: Fix width computation for srcline sort entry tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-09-20 23:50 +0200
[PATCH 11/61] perf tools: Make hist_entry__snprintf function global Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 45/61] perf c2c report: Add stdio output support Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 08/61] perf tools: Make output_field_add and sort_dimension__add global Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 58/61] perf c2c report: Iterate node display in browser Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 49/61] perf c2c report: Add shared cachelines stats stdio output Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 56/61] perf c2c report: Add cacheline index entry Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 27/61] perf c2c report: Add stores related dimension keys Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 36/61] perf c2c report: Add pid sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 57/61] perf c2c report: Add support to manage symbol name length Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 15/61] perf c2c: Add report subcommand Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 37/61] perf c2c report: Add tid sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 39/61] perf c2c report: Add node sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 52/61] perf c2c report: Limit the cachelines table entries Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 09/61] perf tools: Make several sorting functions global Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 38/61] perf c2c report: Add symbol and dso sort keys Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
[PATCH 29/61] perf c2c report: Add llc and remote loads related dimension keys Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
[PATCH 35/61] perf c2c report: Add dram related sort keys Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
[PATCH 17/61] perf c2c report: Add sort_entry dimension support Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
[PATCH 23/61] perf c2c report: Add dcacheline dimension key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
[PATCH 33/61] perf c2c report: Add hitm percent sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
[PATCH 12/61] perf tools: Make hists__fprintf_headers function global Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
[PATCH 28/61] perf c2c report: Add loads related dimension keys Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
[PATCH 05/61] perf tools: Introduce c2c_decode_stats function Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function Nilay Vaish <nilayvaish@gmail.com> - 2016-09-19 19:20 +0200
Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function Joe Mario <jmario@redhat.com> - 2016-09-19 20:10 +0200
Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function Jiri Olsa <jolsa@redhat.com> - 2016-09-21 11:20 +0200
Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function Don Zickus <dzickus@redhat.com> - 2016-09-21 17:20 +0200
Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function Jiri Olsa <jolsa@redhat.com> - 2016-09-21 17:40 +0200
[PATCH 02/61] perf tools: Remove superfluous initialization of weight Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
Re: [PATCH 02/61] perf tools: Remove superfluous initialization of weight Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-21 17:20 +0200
[tip:perf/core] perf evsel: Remove superfluous initialization of weight tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-09-23 07:30 +0200
[PATCH 13/61] perf c2c: Add c2c command Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
[PATCH 34/61] perf c2c report: Add hitm/store percent related sort keys Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
[PATCH 10/61] perf tools: Make several display functions global Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
[PATCH 04/61] perf tools: Use bigger buffer for stdio headers Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
Re: [PATCH 04/61] perf tools: Use bigger buffer for stdio headers Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-21 17:20 +0200
[tip:perf/core] perf hists: Use bigger buffer for stdio headers tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-09-23 07:30 +0200
[PATCH 14/61] perf c2c: Add record subcommand Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
[PATCH 32/61] perf c2c report: Add total loads sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
[PATCH 06/61] perf tools: Introduce c2c_add_stats function Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
[PATCH 31/61] perf c2c report: Add total record sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
[PATCH 07/61] perf tools: Make reset_dimensions global Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
[PATCH 16/61] perf c2c report: Add dimension support Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
[PATCH 30/61] perf c2c report: Add llc load miss dimension key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
[PATCH 18/61] perf c2c report: Fallback to standard dimensions Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
[PATCH 25/61] perf c2c report: Add iaddr dimension key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
csiph-web