Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1486554

Re: [PATCH 61/61] perf tools: Fix width computation for srcline sort entry

Show all headers | View raw

On Mon, Sep 19, 2016 at 11:33:19AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Sep 19, 2016 at 03:10:10PM +0200, Jiri Olsa escreveu:
> > Adding header size to width computation for srcline sort entry,
> > because it's possible to get empty data with ':0' which set width
> > of 2 which is lower than width needed to display column header.
> 
> Thanks, cherry-picked, looking at the larger patchset.

oops, it's on this side of the patchset because it needs
sort_srcline to be global, which is done within the patchset..

I can separate that for v4 if it's needed ;-)

thanks,
jirka

> 
> - Arnaldo
>  
> > Link: http://lkml.kernel.org/n/tip-twbp391v8v9f5idp584hlfov@git.kernel.org
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> >  tools/perf/util/hist.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
> > index 020efa9d3d74..e1be4132054d 100644
> > --- a/tools/perf/util/hist.c
> > +++ b/tools/perf/util/hist.c
> > @@ -177,8 +177,10 @@ void hists__calc_col_len(struct hists *hists, struct hist_entry *h)
> >  	hists__new_col_len(hists, HISTC_LOCAL_WEIGHT, 12);
> >  	hists__new_col_len(hists, HISTC_GLOBAL_WEIGHT, 12);
> >  
> > -	if (h->srcline)
> > -		hists__new_col_len(hists, HISTC_SRCLINE, strlen(h->srcline));
> > +	if (h->srcline) {
> > +		len = MAX(strlen(h->srcline), strlen(sort_srcline.se_header));
> > +		hists__new_col_len(hists, HISTC_SRCLINE, len);
> > +	}
> >  
> >  	if (h->srcfile)
> >  		hists__new_col_len(hists, HISTC_SRCFILE, strlen(h->srcfile));
> > -- 
> > 2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv3 00/61] perf c2c: Add new tool to analyze cacheline contention on NUMA systems Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 50/61] perf c2c report: Add c2c related stats stdio output Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 20/61] perf c2c report: Add cacheline hists processing Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 46/61] perf c2c report: Add main browser Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 51/61] perf c2c report: Allow to report callchains Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 22/61] perf c2c report: Add header macros Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 60/61] perf c2c: Add man page and credits Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 61/61] perf tools: Fix width computation for srcline sort entry Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
    Re: [PATCH 61/61] perf tools: Fix width computation for srcline sort  entry Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-19 16:40 +0200
      Re: [PATCH 61/61] perf tools: Fix width computation for srcline sort  entry Jiri Olsa <jolsa@redhat.com> - 2016-09-19 16:50 +0200
        Re: [PATCH 61/61] perf tools: Fix width computation for srcline sort  entry Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-19 17:00 +0200
    [tip:perf/core] perf hists: Fix width computation for srcline sort  entry tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-09-20 23:50 +0200
  [PATCH 11/61] perf tools: Make hist_entry__snprintf function global Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 45/61] perf c2c report: Add stdio output support Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 08/61] perf tools: Make output_field_add and sort_dimension__add global Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 58/61] perf c2c report: Iterate node display in browser Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 49/61] perf c2c report: Add shared cachelines stats stdio output Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 56/61] perf c2c report: Add cacheline index entry Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 27/61] perf c2c report: Add stores related dimension keys Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 36/61] perf c2c report: Add pid sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 57/61] perf c2c report: Add support to manage symbol name length Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 15/61] perf c2c: Add report subcommand Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 37/61] perf c2c report: Add tid sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 39/61] perf c2c report: Add node sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 52/61] perf c2c report: Limit the cachelines table entries Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 09/61] perf tools: Make several sorting functions global Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 38/61] perf c2c report: Add symbol and dso sort keys Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 29/61] perf c2c report: Add llc and remote loads related dimension keys Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 35/61] perf c2c report: Add dram related sort keys Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 17/61] perf c2c report: Add sort_entry dimension support Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 23/61] perf c2c report: Add dcacheline dimension key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 33/61] perf c2c report: Add hitm percent sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 12/61] perf tools: Make hists__fprintf_headers function global Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 28/61] perf c2c report: Add loads related dimension keys Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 05/61] perf tools: Introduce c2c_decode_stats function Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
    Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function Nilay Vaish <nilayvaish@gmail.com> - 2016-09-19 19:20 +0200
      Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function Joe Mario <jmario@redhat.com> - 2016-09-19 20:10 +0200
    Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function Jiri Olsa <jolsa@redhat.com> - 2016-09-21 11:20 +0200
      Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function Don Zickus <dzickus@redhat.com> - 2016-09-21 17:20 +0200
        Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function Jiri Olsa <jolsa@redhat.com> - 2016-09-21 17:40 +0200
  [PATCH 02/61] perf tools: Remove superfluous initialization of weight Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
    Re: [PATCH 02/61] perf tools: Remove superfluous initialization of  weight Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-21 17:20 +0200
    [tip:perf/core] perf evsel: Remove superfluous initialization of  weight tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-09-23 07:30 +0200
  [PATCH 13/61] perf c2c: Add c2c command Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 34/61] perf c2c report: Add hitm/store percent related sort keys Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 10/61] perf tools: Make several display functions global Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 04/61] perf tools: Use bigger buffer for stdio headers Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
    Re: [PATCH 04/61] perf tools: Use bigger buffer for stdio headers Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-21 17:20 +0200
    [tip:perf/core] perf hists: Use bigger buffer for stdio headers tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-09-23 07:30 +0200
  [PATCH 14/61] perf c2c: Add record subcommand Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 32/61] perf c2c report: Add total loads sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 06/61] perf tools: Introduce c2c_add_stats function Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 31/61] perf c2c report: Add total record sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 07/61] perf tools: Make reset_dimensions global Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 16/61] perf c2c report: Add dimension support Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 30/61] perf c2c report: Add llc load miss dimension key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 18/61] perf c2c report: Fallback to standard dimensions Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 25/61] perf c2c report: Add iaddr dimension key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200

csiph-web