Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function

From	Don Zickus <dzickus@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function
Date	2016-09-21 17:20 +0200
Message-ID	<sjRtv-2de-1@gated-at.bofh.it> (permalink)
References	<sj6Eh-5Vj-3@gated-at.bofh.it> <sj6NY-5YW-27@gated-at.bofh.it> <sjLR8-78t-11@gated-at.bofh.it> <sjLR8-78t-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 21, 2016 at 11:18:29AM +0200, Jiri Olsa wrote:
> On Wed, Sep 21, 2016 at 09:08:40AM +0000, Stanislav Ievlev wrote:
> > Hi, Jiri!
> > 
> > Why are you not using unsigned integer for counters in c2c_stats structure?
> 
> hi,
> never really thought of that, because that's one of the original
> patches I could take almost untouched.. so no real reason ;-)

Hi Jirka,

I can't recall the reason Dick and myself started that way.  I think it
makes sense to use u32 here.  So I am fine with it. :-)

Cheers,
Don

> 
> jirka
> 
> > 
> > On Mon, Sep 19, 2016 at 4:27 PM Jiri Olsa <jolsa@kernel.org> wrote:
> > 
> > > Introducing c2c_decode_stats function, which decodes
> > > data_src data into new struct c2c_stats.
> > >
> > > +struct c2c_stats {
> > > +       int     nr_entries;
> > > +
> > > +       int     locks;               /* count of 'lock' transactions */
> > > +       int     store;               /* count of all stores in trace */
> > > +       int     st_uncache;          /* stores to uncacheable address */
> > > +       int     st_noadrs;           /* cacheable store with no address */
> > > +       int     st_l1hit;            /* count of stores that hit L1D */
> > > +       int     st_l1miss;           /* count of stores that miss L1D */
> > > +       int     load;                /* count of all loads in trace */
> > > +       int     ld_excl;             /* exclusive loads, rmt/lcl DRAM -
> > > snp none/miss */
> > > +       int     ld_shared;           /* shared loads, rmt/lcl DRAM - snp
> > > hit */
> > > +       int     ld_uncache;          /* loads to uncacheable address */
> > > +       int     ld_io;               /* loads to io address */
> > > +       int     ld_miss;             /* loads miss */
> > > +       int     ld_noadrs;           /* cacheable load with no address */
> > > +       int     ld_fbhit;            /* count of loads hitting Fill Buffer
> > > */
> > > +       int     ld_l1hit;            /* count of loads that hit L1D */
> > > +       int     ld_l2hit;            /* count of loads that hit L2D */
> > > +       int     ld_llchit;           /* count of loads that hit LLC */
> > > +       int     lcl_hitm;            /* count of loads with local HITM  */
> > > +       int     rmt_hitm;            /* count of loads with remote HITM */
> > > +       int     rmt_hit;             /* count of loads with remote hit
> > > clean; */
> > > +       int     lcl_dram;            /* count of loads miss to local DRAM
> > > */
> > > +       int     rmt_dram;            /* count of loads miss to remote DRAM
> > > */
> > > +       int     nomap;               /* count of load/stores with no phys
> > > adrs */
> > > +       int     noparse;             /* count of unparsable data sources */
> > > +};
> > >
> > >

Thread

[PATCHv3 00/61] perf c2c: Add new tool to analyze cacheline contention on NUMA systems Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 50/61] perf c2c report: Add c2c related stats stdio output Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 20/61] perf c2c report: Add cacheline hists processing Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 46/61] perf c2c report: Add main browser Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 51/61] perf c2c report: Allow to report callchains Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 22/61] perf c2c report: Add header macros Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 60/61] perf c2c: Add man page and credits Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 61/61] perf tools: Fix width computation for srcline sort entry Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
    Re: [PATCH 61/61] perf tools: Fix width computation for srcline sort  entry Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-19 16:40 +0200
      Re: [PATCH 61/61] perf tools: Fix width computation for srcline sort  entry Jiri Olsa <jolsa@redhat.com> - 2016-09-19 16:50 +0200
        Re: [PATCH 61/61] perf tools: Fix width computation for srcline sort  entry Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-19 17:00 +0200
    [tip:perf/core] perf hists: Fix width computation for srcline sort  entry tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-09-20 23:50 +0200
  [PATCH 11/61] perf tools: Make hist_entry__snprintf function global Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 45/61] perf c2c report: Add stdio output support Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 08/61] perf tools: Make output_field_add and sort_dimension__add global Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 58/61] perf c2c report: Iterate node display in browser Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 49/61] perf c2c report: Add shared cachelines stats stdio output Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 56/61] perf c2c report: Add cacheline index entry Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 27/61] perf c2c report: Add stores related dimension keys Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 36/61] perf c2c report: Add pid sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 57/61] perf c2c report: Add support to manage symbol name length Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 15/61] perf c2c: Add report subcommand Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 37/61] perf c2c report: Add tid sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 39/61] perf c2c report: Add node sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 52/61] perf c2c report: Limit the cachelines table entries Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 09/61] perf tools: Make several sorting functions global Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 38/61] perf c2c report: Add symbol and dso sort keys Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:20 +0200
  [PATCH 29/61] perf c2c report: Add llc and remote loads related dimension keys Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 35/61] perf c2c report: Add dram related sort keys Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 17/61] perf c2c report: Add sort_entry dimension support Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 23/61] perf c2c report: Add dcacheline dimension key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 33/61] perf c2c report: Add hitm percent sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 12/61] perf tools: Make hists__fprintf_headers function global Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 28/61] perf c2c report: Add loads related dimension keys Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 05/61] perf tools: Introduce c2c_decode_stats function Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
    Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function Nilay Vaish <nilayvaish@gmail.com> - 2016-09-19 19:20 +0200
      Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function Joe Mario <jmario@redhat.com> - 2016-09-19 20:10 +0200
    Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function Jiri Olsa <jolsa@redhat.com> - 2016-09-21 11:20 +0200
      Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function Don Zickus <dzickus@redhat.com> - 2016-09-21 17:20 +0200
        Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function Jiri Olsa <jolsa@redhat.com> - 2016-09-21 17:40 +0200
  [PATCH 02/61] perf tools: Remove superfluous initialization of weight Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
    Re: [PATCH 02/61] perf tools: Remove superfluous initialization of  weight Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-21 17:20 +0200
    [tip:perf/core] perf evsel: Remove superfluous initialization of  weight tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-09-23 07:30 +0200
  [PATCH 13/61] perf c2c: Add c2c command Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 34/61] perf c2c report: Add hitm/store percent related sort keys Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 10/61] perf tools: Make several display functions global Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 04/61] perf tools: Use bigger buffer for stdio headers Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
    Re: [PATCH 04/61] perf tools: Use bigger buffer for stdio headers Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-21 17:20 +0200
    [tip:perf/core] perf hists: Use bigger buffer for stdio headers tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-09-23 07:30 +0200
  [PATCH 14/61] perf c2c: Add record subcommand Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 32/61] perf c2c report: Add total loads sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 06/61] perf tools: Introduce c2c_add_stats function Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 31/61] perf c2c report: Add total record sort key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 07/61] perf tools: Make reset_dimensions global Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 16/61] perf c2c report: Add dimension support Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 30/61] perf c2c report: Add llc load miss dimension key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 18/61] perf c2c report: Fallback to standard dimensions Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200
  [PATCH 25/61] perf c2c report: Add iaddr dimension key Jiri Olsa <jolsa@kernel.org> - 2016-09-19 15:30 +0200

csiph-web