Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions

From	Jon Hunter <jonathanh@nvidia.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions
Date	2016-09-20 19:20 +0200
Message-ID	<sjwS5-5V7-1@gated-at.bofh.it> (permalink)
References	<sbcnv-4H8-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 28/08/16 18:32, Paul Kocialkowski wrote:
> This switches a few interrupt definitions that were using
> GPIO_ACTIVE_HIGH as IRQ type, which is invalid.

May be you are right, but this does not describe why this is invalid.
Can you elaborate?

> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  arch/arm/boot/dts/tegra124-nyan.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi b/arch/arm/boot/dts/tegra124-nyan.dtsi
> index 271505e..30a77ec 100644
> --- a/arch/arm/boot/dts/tegra124-nyan.dtsi
> +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
> @@ -59,7 +59,7 @@
>  			compatible = "maxim,max98090";
>  			reg = <0x10>;
>  			interrupt-parent = <&gpio>;
> -			interrupts = <TEGRA_GPIO(H, 4) GPIO_ACTIVE_HIGH>;
> +			interrupts = <TEGRA_GPIO(H, 4) IRQ_TYPE_EDGE_FALLING>;

If this in invalid then the DT binding doc for the max98090 should be
updated as well.

>  		};
>  
>  		temperature-sensor@4c {
> @@ -325,7 +325,7 @@
>  					reg = <0x9>;
>  					interrupt-parent = <&gpio>;
>  					interrupts = <TEGRA_GPIO(J, 0)
> -							GPIO_ACTIVE_HIGH>;
> +							IRQ_TYPE_EDGE_BOTH>;
>  					ti,ac-detect-gpios = <&gpio
>  							TEGRA_GPIO(J, 0)
>  							GPIO_ACTIVE_HIGH>;
> 

Cheers
Jon

-- 
nvpublic

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Jon Hunter <jonathanh@nvidia.com> - 2016-09-20 19:20 +0200
  Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Paul Kocialkowski <contact@paulk.fr> - 2016-09-20 20:20 +0200
    Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Jon Hunter <jonathanh@nvidia.com> - 2016-09-21 10:00 +0200
      Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Paul Kocialkowski <contact@paulk.fr> - 2016-09-21 10:30 +0200
        Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Jon Hunter <jonathanh@nvidia.com> - 2016-09-21 11:10 +0200
          Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Paul Kocialkowski <contact@paulk.fr> - 2016-09-21 11:40 +0200

csiph-web