Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions

From	Paul Kocialkowski <contact@paulk.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions
Date	2016-09-21 10:30 +0200
Message-ID	<sjL4J-6Cq-15@gated-at.bofh.it> (permalink)
References	<sbcnv-4H8-7@gated-at.bofh.it> <sjwS5-5V7-1@gated-at.bofh.it> <sjxO9-6z2-11@gated-at.bofh.it> <sjKBI-6bG-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Le mercredi 21 septembre 2016 à 08:52 +0100, Jon Hunter a écrit :
> On 20/09/16 19:14, Paul Kocialkowski wrote:
> > 
> > * PGP Signed by an unknown key
> > 
> > Le mardi 20 septembre 2016 à 18:15 +0100, Jon Hunter a écrit :
> > > 
> > > On 28/08/16 18:32, Paul Kocialkowski wrote:
> > > > 
> > > > 
> > > > This switches a few interrupt definitions that were using
> > > > GPIO_ACTIVE_HIGH as IRQ type, which is invalid.
> > > 
> > > May be you are right, but this does not describe why this is invalid.
> > > Can you elaborate?
> > 
> > GPIO_ACTIVE_HIGH is simply not the right kind of define to use in the
> > "interrupts" devicetree property. Values provided there are understood as
> > IRQ_TYPE_ defines.
> 
> Right, but you are changing the type as GPIO_ACTIVE_HIGH = 0 and
> IRQ_TYPE_EDGE_FALLING = 2 and there is no comment about why this has
> been changed. It might be correct, but you need to explain it.

This actually makes the IRQ trigger values consistent with the drivers, that
define them regardless of devicetree anyway. The max98090 driver
has IRQF_TRIGGER_FALLING and bq24735 has IRQF_TRIGGER_RISING |
IRQF_TRIGGER_FALLING.

This is really more of a cosmetic change, it doesn't impact actual use.

-- 
Paul Kocialkowski, developer of low-level free software for embedded devices

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/

Thread

Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Jon Hunter <jonathanh@nvidia.com> - 2016-09-20 19:20 +0200
  Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Paul Kocialkowski <contact@paulk.fr> - 2016-09-20 20:20 +0200
    Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Jon Hunter <jonathanh@nvidia.com> - 2016-09-21 10:00 +0200
      Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Paul Kocialkowski <contact@paulk.fr> - 2016-09-21 10:30 +0200
        Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Jon Hunter <jonathanh@nvidia.com> - 2016-09-21 11:10 +0200
          Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Paul Kocialkowski <contact@paulk.fr> - 2016-09-21 11:40 +0200

csiph-web