Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1487884

Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions

Show all headers | View raw

On 20/09/16 19:14, Paul Kocialkowski wrote:
> * PGP Signed by an unknown key
> 
> Le mardi 20 septembre 2016 à 18:15 +0100, Jon Hunter a écrit :
>> On 28/08/16 18:32, Paul Kocialkowski wrote:
>>>
>>> This switches a few interrupt definitions that were using
>>> GPIO_ACTIVE_HIGH as IRQ type, which is invalid.
>>
>> May be you are right, but this does not describe why this is invalid.
>> Can you elaborate?
> 
> GPIO_ACTIVE_HIGH is simply not the right kind of define to use in the
> "interrupts" devicetree property. Values provided there are understood as
> IRQ_TYPE_ defines.

Right, but you are changing the type as GPIO_ACTIVE_HIGH = 0 and
IRQ_TYPE_EDGE_FALLING = 2 and there is no comment about why this has
been changed. It might be correct, but you need to explain it.

Jon

-- 
nvpublic

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Jon Hunter <jonathanh@nvidia.com> - 2016-09-20 19:20 +0200
  Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Paul Kocialkowski <contact@paulk.fr> - 2016-09-20 20:20 +0200
    Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Jon Hunter <jonathanh@nvidia.com> - 2016-09-21 10:00 +0200
      Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Paul Kocialkowski <contact@paulk.fr> - 2016-09-21 10:30 +0200
        Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Jon Hunter <jonathanh@nvidia.com> - 2016-09-21 11:10 +0200
          Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Paul Kocialkowski <contact@paulk.fr> - 2016-09-21 11:40 +0200

csiph-web