Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1485770

[PATCH] mm/mempolicy.c: forbid static or relative flags for local NUMA mode

Show all headers | View raw

The MPOL_F_STATIC_NODES and MPOL_F_RELATIVE_NODES flags are irrelevant
when setting them for MPOL_LOCAL NUMA memory policy via set_mempolicy.
Return the "invalid argument" from set_mempolicy whenever
any of these flags is passed along with MPOL_LOCAL.
It is consistent with MPOL_PREFERRED passed with empty nodemask.
It also slightly shortens the execution time in paths where these flags
are used e.g. when trying to rebind the NUMA nodes for changes in
cgroups cpuset mems (mpol_rebind_preferred()) or when just printing
the mempolicy structure (/proc/PID/numa_maps).
Isolated tests done.

Signed-off-by: Piotr Kwapulinski <kwapulinski.piotr@gmail.com>
---
 mm/mempolicy.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 2da72a5..27b07d1 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -276,7 +276,9 @@ static struct mempolicy *mpol_new(unsigned short mode, unsigned short flags,
 				return ERR_PTR(-EINVAL);
 		}
 	} else if (mode == MPOL_LOCAL) {
-		if (!nodes_empty(*nodes))
+		if (!nodes_empty(*nodes) ||
+		    (flags & MPOL_F_STATIC_NODES) ||
+		    (flags & MPOL_F_RELATIVE_NODES))
 			return ERR_PTR(-EINVAL);
 		mode = MPOL_PREFERRED;
 	} else if (nodes_empty(*nodes))
-- 
2.9.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm/mempolicy.c: forbid static or relative flags for local NUMA mode Piotr Kwapulinski <kwapulinski.piotr@gmail.com> - 2016-09-18 13:40 +0200
  Re: [PATCH] mm/mempolicy.c: forbid static or relative flags for  local NUMA mode Michal Hocko <mhocko@kernel.org> - 2016-09-19 14:00 +0200
    Re: [PATCH] mm/mempolicy.c: forbid static or relative flags for  local NUMA mode Piotr Kwapulinski <kwapulinski.piotr@gmail.com> - 2016-09-20 17:50 +0200
  Re: [PATCH] mm/mempolicy.c: forbid static or relative flags for  local NUMA mode David Rientjes <rientjes@google.com> - 2016-09-20 03:00 +0200
    Re: [PATCH] mm/mempolicy.c: forbid static or relative flags for  local NUMA mode Piotr Kwapulinski <kwapulinski.piotr@gmail.com> - 2016-09-20 18:00 +0200
      Re: [PATCH] mm/mempolicy.c: forbid static or relative flags for  local NUMA mode David Rientjes <rientjes@google.com> - 2016-09-20 22:10 +0200
  Re: [PATCH] mm/mempolicy.c: forbid static or relative flags for local  NUMA mode Vlastimil Babka <vbabka@suse.cz> - 2016-09-20 17:20 +0200
    Re: [PATCH] mm/mempolicy.c: forbid static or relative flags for  local NUMA mode Piotr Kwapulinski <kwapulinski.piotr@gmail.com> - 2016-09-20 18:30 +0200

csiph-web