Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1485769
| From | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net: mvneta: mark symbols static where possible |
| Date | 2016-09-18 13:40 +0200 |
| Message-ID | <siIBX-7x4-3@gated-at.bofh.it> (permalink) |
| References | <siGA9-6ms-1@gated-at.bofh.it> |
| Organization | Free Electrons |
Hello, On Sun, 18 Sep 2016 17:20:45 +0800, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/net/ethernet/marvell/mvneta.c:639:27: warning: no previous prototype for 'mvneta_get_stats64' [-Wmissing-prototypes] > drivers/net/ethernet/marvell/mvneta.c:3529:5: warning: no previous prototype for 'mvneta_ethtool_set_link_ksettings' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] net: mvneta: mark symbols static where possible Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-18 11:30 +0200 Re: [PATCH] net: mvneta: mark symbols static where possible Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-09-18 13:40 +0200 Re: [PATCH] net: mvneta: mark symbols static where possible Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-09-18 14:10 +0200
csiph-web