Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1487464

Re: [PATCH] mm/mempolicy.c: forbid static or relative flags for local NUMA mode

Show all headers | View raw

On Mon, Sep 19, 2016 at 05:57:17PM -0700, David Rientjes wrote:
> On Sun, 18 Sep 2016, Piotr Kwapulinski wrote:
> 
> > The MPOL_F_STATIC_NODES and MPOL_F_RELATIVE_NODES flags are irrelevant
> > when setting them for MPOL_LOCAL NUMA memory policy via set_mempolicy.
> > Return the "invalid argument" from set_mempolicy whenever
> > any of these flags is passed along with MPOL_LOCAL.
> > It is consistent with MPOL_PREFERRED passed with empty nodemask.
> > It also slightly shortens the execution time in paths where these flags
> > are used e.g. when trying to rebind the NUMA nodes for changes in
> > cgroups cpuset mems (mpol_rebind_preferred()) or when just printing
> > the mempolicy structure (/proc/PID/numa_maps).
> > Isolated tests done.
> > 
> > Signed-off-by: Piotr Kwapulinski <kwapulinski.piotr@gmail.com>
> 
> Acked-by: David Rientjes <rientjes@google.com>
> 
> There wasn't an MPOL_LOCAL when I introduced either of these flags, it's 
> an oversight to allow them to be passed.
> 
> Want to try to update set_mempolicy(2) with the procedure outlined in 
> https://www.kernel.org/doc/man-pages/patches.html as well?
Yes, why not ? I'll put a note about it.

--
Piotr Kwapulinski

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm/mempolicy.c: forbid static or relative flags for local NUMA mode Piotr Kwapulinski <kwapulinski.piotr@gmail.com> - 2016-09-18 13:40 +0200
  Re: [PATCH] mm/mempolicy.c: forbid static or relative flags for  local NUMA mode Michal Hocko <mhocko@kernel.org> - 2016-09-19 14:00 +0200
    Re: [PATCH] mm/mempolicy.c: forbid static or relative flags for  local NUMA mode Piotr Kwapulinski <kwapulinski.piotr@gmail.com> - 2016-09-20 17:50 +0200
  Re: [PATCH] mm/mempolicy.c: forbid static or relative flags for  local NUMA mode David Rientjes <rientjes@google.com> - 2016-09-20 03:00 +0200
    Re: [PATCH] mm/mempolicy.c: forbid static or relative flags for  local NUMA mode Piotr Kwapulinski <kwapulinski.piotr@gmail.com> - 2016-09-20 18:00 +0200
      Re: [PATCH] mm/mempolicy.c: forbid static or relative flags for  local NUMA mode David Rientjes <rientjes@google.com> - 2016-09-20 22:10 +0200
  Re: [PATCH] mm/mempolicy.c: forbid static or relative flags for local  NUMA mode Vlastimil Babka <vbabka@suse.cz> - 2016-09-20 17:20 +0200
    Re: [PATCH] mm/mempolicy.c: forbid static or relative flags for  local NUMA mode Piotr Kwapulinski <kwapulinski.piotr@gmail.com> - 2016-09-20 18:30 +0200

csiph-web