Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1478978

Re: [PATCH v2 11/19] remoteproc: core: Add function to get resource table spare bytes information

Show all headers | View raw

On 09/08/2016 10:32 AM, Lee Jones wrote:
> On Wed, 31 Aug 2016, Loic Pallardy wrote:
>
>> Remoteproc needs to know if a resource table has spare resource
>> allowing resoure table extension.
>> This function parse resource table to detect spare resource.
>> If any, it returns available spare bytes and index of spare resource.
>>
>> Signed-off-by: Loic Pallardy <loic.pallardy@st.com>
>> ---
>>  drivers/remoteproc/remoteproc_core.c | 29 +++++++++++++++++++++++++++++
>>  1 file changed, 29 insertions(+)
>>
>> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
>> index ffb56c0..30e9c70 100644
>> --- a/drivers/remoteproc/remoteproc_core.c
>> +++ b/drivers/remoteproc/remoteproc_core.c
>> @@ -951,6 +951,35 @@ int rproc_request_resource(struct rproc *rproc, u32 type, u32 action, void *reso
>>  }
>>  EXPORT_SYMBOL(rproc_request_resource);
>>
>> +static int __get_rsc_tbl_spare_size(struct rproc *rproc,
>
> size_t?
ok
>
>> +					  struct resource_table *table_ptr, int len,
>> +					  int *spare_index)
>> +{
>> +	struct device *dev = &rproc->dev;
>> +	int i;
>> +
>> +	for (i = 0; i < table_ptr->num; i++) {
>> +		int offset = table_ptr->offset[i];
>> +		struct fw_rsc_hdr *hdr = (void *)table_ptr + offset;
>> +		struct fw_rsc_spare *spare = (void *)hdr + sizeof(*hdr);
>> +
>> +		dev_dbg(dev, "rsc: type %d\n", hdr->type);
>
> This doesn't need to be in upstream code.
Sure
>
>> +		if (hdr->type >= RSC_LAST) {
>> +			dev_warn(dev, "unsupported resource %d\n", hdr->type);
>> +			continue;
>> +		}
>
> If we're only interested in RSC_SPARE, I think we can omit this check.
>
> No need to police the resource table everywhere.
True and complete table sanity check done before.
I'll remove
Thanks,
Loic

>
>> +		if (hdr->type != RSC_SPARE)
>> +			continue;
>> +
>> +		*spare_index = i;
>> +		return spare->len;
>> +	}
>> +
>> +	return 0;
>> +}
>> +
>>  static int __verify_rsc_tbl_entry(struct rproc *rproc,
>>  				struct rproc_request_resource *request,
>>  				struct resource_table *table, int size)
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/19] remoteproc: Allow platform-specific drivers to request resources Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
  [PATCH v2 11/19] remoteproc: core: Add function to get resource table spare bytes information Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
    Re: [PATCH v2 11/19] remoteproc: core: Add function to get resource  table spare bytes information Lee Jones <lee.jones@linaro.org> - 2016-09-08 10:40 +0200
      Re: [PATCH v2 11/19] remoteproc: core: Add function to get resource  table spare bytes information loic pallardy <loic.pallardy@st.com> - 2016-09-08 11:50 +0200
  [PATCH v2 19/19] remoteproc: core: Support empty resource tables Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
  [PATCH v2 13/19] remoteproc: core: Append resource only if spare resource present Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
    Re: [PATCH v2 13/19] remoteproc: core: Append resource only if spare  resource present Lee Jones <lee.jones@linaro.org> - 2016-09-08 11:40 +0200
      Re: [PATCH v2 13/19] remoteproc: core: Append resource only if spare  resource present loic pallardy <loic.pallardy@st.com> - 2016-09-08 12:00 +0200
        Re: [PATCH v2 13/19] remoteproc: core: Append resource only if spare  resource present Lee Jones <lee.jones@linaro.org> - 2016-09-08 13:00 +0200
  [PATCH v2 01/19] remoteproc: core: New API to add new resources to the resource table Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
  [PATCH v2 17/19] remotecore: core: Add resource table pointer argument to rproc_handle_resource Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
  [PATCH v2 09/19] remoteproc: core: Finalize dump resource table function Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
    Re: [PATCH v2 09/19] remoteproc: core: Finalize dump resource table  function Lee Jones <lee.jones@linaro.org> - 2016-09-08 10:30 +0200
      Re: [PATCH v2 09/19] remoteproc: core: Finalize dump resource table  function loic pallardy <loic.pallardy@st.com> - 2016-09-08 11:50 +0200
  [PATCH v2 18/19] remoteproc: core: Add function to create remoteproc local resource table Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
    Re: [PATCH v2 18/19] remoteproc: core: Add function to create  remoteproc local resource table Lee Jones <lee.jones@linaro.org> - 2016-09-08 12:20 +0200
      Re: [PATCH v2 18/19] remoteproc: core: Add function to create  remoteproc local resource table loic pallardy <loic.pallardy@st.com> - 2016-09-08 15:20 +0200
  [PATCH v2 14/19] remoteproc: core: Add resource request action support Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
  [PATCH v2 03/19] remoteproc: core: Add function to amend an existing resource table entry Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
  [PATCH v2 02/19] remoteproc: core: Add function to dump resource table Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200

csiph-web