Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1473862

[PATCH v2 09/19] remoteproc: core: Finalize dump resource table function

From Loic Pallardy <loic.pallardy@st.com>
Newsgroups linux.kernel
Subject [PATCH v2 09/19] remoteproc: core: Finalize dump resource table function
Date 2016-08-31 23:00 +0200
Message-ID <sckM3-7eb-51@gated-at.bofh.it> (permalink)
References <sckM1-7eb-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Diverse updates:
- add cfg field display of vdev struct
- add support of spare resource
- put rproc_dump_resource_table under DEBUG compilation flag

Signed-off-by: Loic Pallardy <loic.pallardy@st.com>
---
 drivers/remoteproc/remoteproc_core.c | 31 ++++++++++++++++++++++++++++---
 1 file changed, 28 insertions(+), 3 deletions(-)

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index cd64fae..345bdfb 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -791,15 +791,17 @@ static void rproc_resource_cleanup(struct rproc *rproc)
 		rproc_remove_virtio_dev(rvdev);
 }
 
+#if defined(DEBUG)
 static void rproc_dump_resource_table(struct rproc *rproc,
 				      struct resource_table *table, int size)
 {
-	const char *types[] = {"carveout", "devmem", "trace", "vdev"};
+	static const char *types[] = {"carveout", "devmem", "trace", "vdev", "spare"};
 	struct device *dev = &rproc->dev;
 	struct fw_rsc_carveout *c;
 	struct fw_rsc_devmem *d;
 	struct fw_rsc_trace *t;
 	struct fw_rsc_vdev *v;
+	struct fw_rsc_spare *s;
 	int i, j;
 
 	if (!table) {
@@ -814,6 +816,8 @@ static void rproc_dump_resource_table(struct rproc *rproc,
 		int offset = table->offset[i];
 		struct fw_rsc_hdr *hdr = (void *)table + offset;
 		void *rsc = (void *)hdr + sizeof(*hdr);
+		unsigned char *cfg;
+		int len;
 
 		switch (hdr->type) {
 		case RSC_CARVEOUT:
@@ -867,14 +871,35 @@ static void rproc_dump_resource_table(struct rproc *rproc,
 				dev_dbg(dev, "    Reserved (should be zero) [%d]\n\n",
 					v->vring[j].reserved);
 			}
+
+			dev_dbg(dev, "  Config table\n");
+			cfg = (unsigned char *)(&v->vring[v->num_of_vrings]);
+			len = 0;
+			do {
+				j = min(16, v->config_len - len);
+				dev_dbg(dev, "    Config[%2d-%2d] = %*phC\n",
+					len, len + j - 1, j, cfg + len);
+				len += j;
+			} while (len < v->config_len);
+
+			break;
+		case RSC_SPARE:
+			s = rsc;
+			dev_dbg(dev, "Entry %d is of type %s\n", i, types[hdr->type]);
+			dev_dbg(dev, "  Spare size: 0x%x bytes\n\n", s->len);
 			break;
 		default:
-			dev_dbg(dev, "Invalid resource type found: %d [hdr: %p]\n",
-				hdr->type, hdr);
+			dev_dbg(dev, "Entry %d: Invalid resource type found: %d [hdr: %p]\n",
+				i, hdr->type, hdr);
 			return;
 		}
 	}
 }
+#else
+static inline void rproc_dump_resource_table(struct rproc *rproc,
+				      struct resource_table *table, int size)
+{}
+#endif
 
 int rproc_request_resource(struct rproc *rproc, u32 type, u32 action, void *resource)
 {
-- 
1.9.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 00/19] remoteproc: Allow platform-specific drivers to request resources Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
  [PATCH v2 11/19] remoteproc: core: Add function to get resource table spare bytes information Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
    Re: [PATCH v2 11/19] remoteproc: core: Add function to get resource  table spare bytes information Lee Jones <lee.jones@linaro.org> - 2016-09-08 10:40 +0200
      Re: [PATCH v2 11/19] remoteproc: core: Add function to get resource  table spare bytes information loic pallardy <loic.pallardy@st.com> - 2016-09-08 11:50 +0200
  [PATCH v2 19/19] remoteproc: core: Support empty resource tables Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
  [PATCH v2 13/19] remoteproc: core: Append resource only if spare resource present Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
    Re: [PATCH v2 13/19] remoteproc: core: Append resource only if spare  resource present Lee Jones <lee.jones@linaro.org> - 2016-09-08 11:40 +0200
      Re: [PATCH v2 13/19] remoteproc: core: Append resource only if spare  resource present loic pallardy <loic.pallardy@st.com> - 2016-09-08 12:00 +0200
        Re: [PATCH v2 13/19] remoteproc: core: Append resource only if spare  resource present Lee Jones <lee.jones@linaro.org> - 2016-09-08 13:00 +0200
  [PATCH v2 01/19] remoteproc: core: New API to add new resources to the resource table Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
  [PATCH v2 17/19] remotecore: core: Add resource table pointer argument to rproc_handle_resource Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
  [PATCH v2 09/19] remoteproc: core: Finalize dump resource table function Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
    Re: [PATCH v2 09/19] remoteproc: core: Finalize dump resource table  function Lee Jones <lee.jones@linaro.org> - 2016-09-08 10:30 +0200
      Re: [PATCH v2 09/19] remoteproc: core: Finalize dump resource table  function loic pallardy <loic.pallardy@st.com> - 2016-09-08 11:50 +0200
  [PATCH v2 18/19] remoteproc: core: Add function to create remoteproc local resource table Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
    Re: [PATCH v2 18/19] remoteproc: core: Add function to create  remoteproc local resource table Lee Jones <lee.jones@linaro.org> - 2016-09-08 12:20 +0200
      Re: [PATCH v2 18/19] remoteproc: core: Add function to create  remoteproc local resource table loic pallardy <loic.pallardy@st.com> - 2016-09-08 15:20 +0200
  [PATCH v2 14/19] remoteproc: core: Add resource request action support Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
  [PATCH v2 03/19] remoteproc: core: Add function to amend an existing resource table entry Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
  [PATCH v2 02/19] remoteproc: core: Add function to dump resource table Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200

csiph-web