Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1473858

[PATCH v2 19/19] remoteproc: core: Support empty resource tables

Show all headers | View raw

From: Lee Jones <lee.jones@linaro.org>

Currently, when a remote processor does not require resources, the
platform-specific remoteproc driver has to create a fake resource
table in order to by-pass the strict checking.  But there is no hard
requirement for a remote processor so require or support shared
resources.  This patch removes the strict checking and skips
resource table related operations if none is provided.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Loic Pallardy <loic.pallardy@st.com>
---
 drivers/remoteproc/remoteproc_core.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 73b460a..235ca2a 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -685,6 +685,9 @@ static int rproc_handle_resources(struct rproc *rproc, struct resource_table *ta
 	rproc_handle_resource_t handler;
 	int ret = 0, i;
 
+	if (!table_ptr)
+		return ret;
+
 	for (i = 0; i < table_ptr->num; i++) {
 		int offset = table_ptr->offset[i];
 		struct fw_rsc_hdr *hdr = (void *)table_ptr + offset;
@@ -1337,7 +1340,7 @@ static int rproc_fw_boot(struct rproc *rproc, const struct firmware *fw)
 	struct device *dev = &rproc->dev;
 	const char *name = rproc->firmware;
 	struct resource_table *table, *loaded_table;
-	int ret, tablesz, local_tablesz;
+	int ret, tablesz = 0, local_tablesz;
 
 	ret = rproc_fw_sanity_check(rproc, fw);
 	if (ret)
@@ -1361,8 +1364,8 @@ static int rproc_fw_boot(struct rproc *rproc, const struct firmware *fw)
 	/* look for the resource table */
 	table = rproc_find_rsc_table(rproc, fw, &tablesz);
 	if (!table) {
-		dev_err(dev, "Failed to find resource table\n");
-		goto clean_up;
+		rproc->cached_table = table;
+		goto skip_resources;
 	}
 
 	/*  verify resource table consistency */
@@ -1384,6 +1387,7 @@ static int rproc_fw_boot(struct rproc *rproc, const struct firmware *fw)
 		goto clean_up;
 	}
 
+skip_resources:
 	rproc->table_ptr = rproc->cached_table;
 
 	if (!list_empty(&rproc->override_resources)) {
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/19] remoteproc: Allow platform-specific drivers to request resources Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
  [PATCH v2 11/19] remoteproc: core: Add function to get resource table spare bytes information Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
    Re: [PATCH v2 11/19] remoteproc: core: Add function to get resource  table spare bytes information Lee Jones <lee.jones@linaro.org> - 2016-09-08 10:40 +0200
      Re: [PATCH v2 11/19] remoteproc: core: Add function to get resource  table spare bytes information loic pallardy <loic.pallardy@st.com> - 2016-09-08 11:50 +0200
  [PATCH v2 19/19] remoteproc: core: Support empty resource tables Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
  [PATCH v2 13/19] remoteproc: core: Append resource only if spare resource present Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
    Re: [PATCH v2 13/19] remoteproc: core: Append resource only if spare  resource present Lee Jones <lee.jones@linaro.org> - 2016-09-08 11:40 +0200
      Re: [PATCH v2 13/19] remoteproc: core: Append resource only if spare  resource present loic pallardy <loic.pallardy@st.com> - 2016-09-08 12:00 +0200
        Re: [PATCH v2 13/19] remoteproc: core: Append resource only if spare  resource present Lee Jones <lee.jones@linaro.org> - 2016-09-08 13:00 +0200
  [PATCH v2 01/19] remoteproc: core: New API to add new resources to the resource table Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
  [PATCH v2 17/19] remotecore: core: Add resource table pointer argument to rproc_handle_resource Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
  [PATCH v2 09/19] remoteproc: core: Finalize dump resource table function Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
    Re: [PATCH v2 09/19] remoteproc: core: Finalize dump resource table  function Lee Jones <lee.jones@linaro.org> - 2016-09-08 10:30 +0200
      Re: [PATCH v2 09/19] remoteproc: core: Finalize dump resource table  function loic pallardy <loic.pallardy@st.com> - 2016-09-08 11:50 +0200
  [PATCH v2 18/19] remoteproc: core: Add function to create remoteproc local resource table Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
    Re: [PATCH v2 18/19] remoteproc: core: Add function to create  remoteproc local resource table Lee Jones <lee.jones@linaro.org> - 2016-09-08 12:20 +0200
      Re: [PATCH v2 18/19] remoteproc: core: Add function to create  remoteproc local resource table loic pallardy <loic.pallardy@st.com> - 2016-09-08 15:20 +0200
  [PATCH v2 14/19] remoteproc: core: Add resource request action support Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
  [PATCH v2 03/19] remoteproc: core: Add function to amend an existing resource table entry Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200
  [PATCH v2 02/19] remoteproc: core: Add function to dump resource table Loic Pallardy <loic.pallardy@st.com> - 2016-08-31 23:00 +0200

csiph-web