Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1477932

Re: [PATCH 3/4] ARM: orion5x: avoid NO_IRQ in orion_ge00_switch_init

Show all headers | View raw

On Tue, Sep 06, 2016 at 04:06:22PM +0200, Arnd Bergmann wrote:
> As of commit 5be9fc23cdb4 ("ARM: orion5x: fix legacy orion5x IRQ numbers"),
> IRQ zero is no longer a valid interrupt on Orion5x, so we can use the
> normal convention of using '0' to indicate an invalid interrupt, rather
> than the deprecated NO_IRQ constant
> 
> My first approach was to pass a pointer to the resource into
> orion_ge00_switch_init(), but it seemed to just add complexity
> for no good.

Hi Arnd

You can simply this. DSA has never as far as i remember used an
interrupt passed via platform data. Two boards do seem to pass an
interrupt via a GPIO line, but it has never been used.

So if you want, you could strip all this interrupt code out.

There might be some patches coming soon which does add interrupt
support to DSA, but it will only be via device tree, since i don't
have a platform which is capable of using platform data for DSA.

   Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] ARM: mv78xx0: simplify ethernet device creation Arnd Bergmann <arnd@arndb.de> - 2016-09-06 16:10 +0200
  [PATCH 2/4] ARM: mvebu/orion: remove NO_IRQ check from device init Arnd Bergmann <arnd@arndb.de> - 2016-09-06 16:10 +0200
  [PATCH 3/4] ARM: orion5x: avoid NO_IRQ in orion_ge00_switch_init Arnd Bergmann <arnd@arndb.de> - 2016-09-06 16:10 +0200
    Re: [PATCH 3/4] ARM: orion5x: avoid NO_IRQ in orion_ge00_switch_init Andrew Lunn <andrew@lunn.ch> - 2016-09-07 04:10 +0200
      Re: [PATCH 3/4] ARM: orion5x: avoid NO_IRQ in orion_ge00_switch_init Arnd Bergmann <arnd@arndb.de> - 2016-09-08 17:30 +0200
  Re: [PATCH 1/4] ARM: mv78xx0: simplify ethernet device creation Andrew Lunn <andrew@lunn.ch> - 2016-09-07 03:40 +0200

csiph-web