Re: [PATCH] x86: Put the num_processors++ code in a more suitable position

From	Dou Liyang <douly.fnst@cn.fujitsu.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86: Put the num_processors++ code in a more suitable position
Date	2016-09-07 04:10 +0200
Message-ID	<seAtk-1Sb-7@gated-at.bofh.it> (permalink)
References	<sehh0-64g-11@gated-at.bofh.it> <sew6l-7po-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi David,

At 09/07/2016 05:23 AM, David Rientjes wrote:
> On Tue, 6 Sep 2016, Dou Liyang wrote:
>
>> This is a code optimization.
>>
>
> Not sure that it's optimization, it's just for correctness.

Yes, I see. I will improve it in next version.

Thanks,
Dou

>
>> If checking the topology package map of apicid and cpu is failure,
>> it will stop generating the processor info for that apicid and the
>> disabled_cpus will plus one. However, the num-processors has already
>> been added one above. That may cause the number of processors incorrect.
>>
>> Just put the num_processors++ code in the more suitable position.
>> it makes sure that the num-processors will not conflict with the
>> disabled_cpus.
>>
>> Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
>
> Acked-by: David Rientjes <rientjes@google.com>
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] x86: Put the num_processors++ code in a more suitable position Dou Liyang <douly.fnst@cn.fujitsu.com> - 2016-09-06 07:40 +0200
  Re: [PATCH] x86: Put the num_processors++ code in a more suitable  position David Rientjes <rientjes@google.com> - 2016-09-06 23:30 +0200
    Re: [PATCH] x86: Put the num_processors++ code in a more suitable  position Dou Liyang <douly.fnst@cn.fujitsu.com> - 2016-09-07 04:10 +0200

csiph-web