Re: [PATCH 0/2] lan78xx: Remove trailing underscores from macros

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/2] lan78xx: Remove trailing underscores from macros
Date	2016-09-07 04:20 +0200
Message-ID	<seACZ-25t-1@gated-at.bofh.it> (permalink)
References	<sexF7-95-3@gated-at.bofh.it> <sexON-c9-3@gated-at.bofh.it> <seACZ-25t-3@gated-at.bofh.it> <seAtk-1Sb-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2016-09-07 at 02:00 +0000, Ronnie.Kunin@microchip.com wrote:
> Microchip's internal convention is for register (offset) definitions
> to be capitalized (i.e.: MY_REGISTER). Our convention for bits
> (position) definitions within a register is to carry as a prefix the
> name of the register and suffix it with the bit name and adding a
> trailing underscore (i.e. MY_REGISTER_MY_BIT_). The trailing
> underscore is what easily lets us distinguish a bit from a register
> definition when reading code. We have been using this convention for
> many years and has worked very well for us across all projects (by now
> hundreds).

I think it's kind of an ugly convention, but <shrug> no
skin off my nose really.

> > Is there anything other than a one-time cost
> > to apply these?  Is the same code used for
> > other platforms?
> 
> Yes, a single header file with the definition of registers and bits is
> shared (either as a standalone file or with its contents pasted into a
> native environment "carrier" header file) across all drivers (and
> other non driver software projects as well) for the same device. So a
> change like this indeed has a high cost for Microchip and we'd rather
> not do this unless it is an absolutely mandated requirement. 

No worries, if you don't like it, don't apply it.

Send a NAK too so David Miller doesn't apply it either.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] lan78xx: Remove trailing underscores from macros Joe Perches <joe@perches.com> - 2016-09-07 01:10 +0200
  RE: [PATCH 0/2] lan78xx: Remove trailing underscores from macros <Woojung.Huh@microchip.com> - 2016-09-07 01:20 +0200
    Re: [PATCH 0/2] lan78xx: Remove trailing underscores from macros Joe Perches <joe@perches.com> - 2016-09-07 03:30 +0200
      RE: [PATCH 0/2] lan78xx: Remove trailing underscores from macros <Ronnie.Kunin@microchip.com> - 2016-09-07 04:10 +0200
        Re: [PATCH 0/2] lan78xx: Remove trailing underscores from macros Joe Perches <joe@perches.com> - 2016-09-07 04:20 +0200

csiph-web