Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1476039

[PATCH net-next 7/9] fs/afs/rxrpc: Remove deprecated create_singlethread_workqueue

From David Howells <dhowells@redhat.com>
Newsgroups linux.kernel
Subject [PATCH net-next 7/9] fs/afs/rxrpc: Remove deprecated create_singlethread_workqueue
Date 2016-09-04 23:20 +0200
Message-ID <sdMZA-2No-13@gated-at.bofh.it> (permalink)
References <sdMPU-2JV-11@gated-at.bofh.it>
Organization Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw


From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>

The workqueue "afs_async_calls" queues work item
&call->async_work per afs_call. Since there could be multiple calls and since
these calls can be run concurrently, alloc_workqueue has been used to replace
the deprecated create_singlethread_workqueue instance.

The WQ_MEM_RECLAIM flag has been set to ensure forward progress under
memory pressure because the workqueue is being used on a memory reclaim
path.

Since there are fixed number of work items, explicit concurrency
limit is unnecessary here.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
---

 fs/afs/rxrpc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/afs/rxrpc.c b/fs/afs/rxrpc.c
index 244896baf241..37608be52abd 100644
--- a/fs/afs/rxrpc.c
+++ b/fs/afs/rxrpc.c
@@ -76,7 +76,7 @@ int afs_open_socket(void)
 	_enter("");
 
 	ret = -ENOMEM;
-	afs_async_calls = create_singlethread_workqueue("kafsd");
+	afs_async_calls = alloc_workqueue("kafsd", WQ_MEM_RECLAIM, 0);
 	if (!afs_async_calls)
 		goto error_0;
 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net-next 0/9] rxrpc: Small fixes David Howells <dhowells@redhat.com> - 2016-09-04 23:10 +0200
  [PATCH net-next 9/9] fs/afs/flock: Remove deprecated  create_singlethread_workqueue David Howells <dhowells@redhat.com> - 2016-09-04 23:10 +0200
  [PATCH net-next 5/9] rxrpc: Don't change the epoch David Howells <dhowells@redhat.com> - 2016-09-04 23:10 +0200
  [PATCH net-next 6/9] fs/afs/vlocation: Remove deprecated  create_singlethread_workqueue David Howells <dhowells@redhat.com> - 2016-09-04 23:20 +0200
  [PATCH net-next 3/9] rxrpc: The client call state must be changed  before attachment to conn David Howells <dhowells@redhat.com> - 2016-09-04 23:20 +0200
  [PATCH net-next 4/9] rxrpc: Randomise epoch and starting client  conn ID values David Howells <dhowells@redhat.com> - 2016-09-04 23:20 +0200
    RE: [PATCH net-next 4/9] rxrpc: Randomise epoch and starting client  conn ID values David Laight <David.Laight@ACULAB.COM> - 2016-09-05 17:10 +0200
      Re: [PATCH net-next 4/9] rxrpc: Randomise epoch and starting client conn ID values David Howells <dhowells@redhat.com> - 2016-09-05 18:30 +0200
        Re: [PATCH net-next 4/9] rxrpc: Randomise epoch and starting client  conn ID values Jeffrey Altman <jaltman@auristor.com> - 2016-09-06 04:20 +0200
  [PATCH net-next 7/9] fs/afs/rxrpc: Remove deprecated  create_singlethread_workqueue David Howells <dhowells@redhat.com> - 2016-09-04 23:20 +0200
  [PATCH net-next 8/9] fs/afs/callback: Remove deprecated  create_singlethread_workqueue David Howells <dhowells@redhat.com> - 2016-09-04 23:20 +0200
  Re: [PATCH net-next 0/9] rxrpc: Small fixes David Miller <davem@davemloft.net> - 2016-09-06 23:00 +0200

csiph-web