Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1476032
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH net-next 9/9] fs/afs/flock: Remove deprecated create_singlethread_workqueue |
| Date | 2016-09-04 23:10 +0200 |
| Message-ID | <sdMPU-2JV-23@gated-at.bofh.it> (permalink) |
| References | <sdMPU-2JV-11@gated-at.bofh.it> |
| Organization | Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 |
From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
The workqueue "afs_lock_manager" queues work item &vnode->lock_work,
per vnode. Since there can be multiple vnodes and since their work items
can be executed concurrently, alloc_workqueue has been used to replace
the deprecated create_singlethread_workqueue instance.
The WQ_MEM_RECLAIM flag has been set to ensure forward progress under
memory pressure because the workqueue is being used on a memory reclaim
path.
Since there are fixed number of work items, explicit concurrency
limit is unnecessary here.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
---
fs/afs/flock.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/afs/flock.c b/fs/afs/flock.c
index d91a9c9cfbd0..3191dff2c156 100644
--- a/fs/afs/flock.c
+++ b/fs/afs/flock.c
@@ -36,8 +36,8 @@ static int afs_init_lock_manager(void)
if (!afs_lock_manager) {
mutex_lock(&afs_lock_manager_mutex);
if (!afs_lock_manager) {
- afs_lock_manager =
- create_singlethread_workqueue("kafs_lockd");
+ afs_lock_manager = alloc_workqueue("kafs_lockd",
+ WQ_MEM_RECLAIM, 0);
if (!afs_lock_manager)
ret = -ENOMEM;
}
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next 0/9] rxrpc: Small fixes David Howells <dhowells@redhat.com> - 2016-09-04 23:10 +0200
[PATCH net-next 9/9] fs/afs/flock: Remove deprecated create_singlethread_workqueue David Howells <dhowells@redhat.com> - 2016-09-04 23:10 +0200
[PATCH net-next 5/9] rxrpc: Don't change the epoch David Howells <dhowells@redhat.com> - 2016-09-04 23:10 +0200
[PATCH net-next 6/9] fs/afs/vlocation: Remove deprecated create_singlethread_workqueue David Howells <dhowells@redhat.com> - 2016-09-04 23:20 +0200
[PATCH net-next 3/9] rxrpc: The client call state must be changed before attachment to conn David Howells <dhowells@redhat.com> - 2016-09-04 23:20 +0200
[PATCH net-next 4/9] rxrpc: Randomise epoch and starting client conn ID values David Howells <dhowells@redhat.com> - 2016-09-04 23:20 +0200
RE: [PATCH net-next 4/9] rxrpc: Randomise epoch and starting client conn ID values David Laight <David.Laight@ACULAB.COM> - 2016-09-05 17:10 +0200
Re: [PATCH net-next 4/9] rxrpc: Randomise epoch and starting client conn ID values David Howells <dhowells@redhat.com> - 2016-09-05 18:30 +0200
Re: [PATCH net-next 4/9] rxrpc: Randomise epoch and starting client conn ID values Jeffrey Altman <jaltman@auristor.com> - 2016-09-06 04:20 +0200
[PATCH net-next 7/9] fs/afs/rxrpc: Remove deprecated create_singlethread_workqueue David Howells <dhowells@redhat.com> - 2016-09-04 23:20 +0200
[PATCH net-next 8/9] fs/afs/callback: Remove deprecated create_singlethread_workqueue David Howells <dhowells@redhat.com> - 2016-09-04 23:20 +0200
Re: [PATCH net-next 0/9] rxrpc: Small fixes David Miller <davem@davemloft.net> - 2016-09-06 23:00 +0200
csiph-web