Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1476040

[PATCH net-next 8/9] fs/afs/callback: Remove deprecated create_singlethread_workqueue

From David Howells <dhowells@redhat.com>
Newsgroups linux.kernel
Subject [PATCH net-next 8/9] fs/afs/callback: Remove deprecated create_singlethread_workqueue
Date 2016-09-04 23:20 +0200
Message-ID <sdMZA-2No-11@gated-at.bofh.it> (permalink)
References <sdMPU-2JV-11@gated-at.bofh.it>
Organization Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw


From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>

The workqueue "afs_callback_update_worker" queues multiple work items
viz  &vnode->cb_broken_work, &server->cb_break_work which require strict
execution ordering. Hence, an ordered dedicated workqueue has been used.

Since the workqueue is being used on a memory reclaim path, WQ_MEM_RECLAIM
has been set to ensure forward progress under memory pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
---

 fs/afs/callback.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/afs/callback.c b/fs/afs/callback.c
index 7ef637d7f3a5..1e9d2f84e5b5 100644
--- a/fs/afs/callback.c
+++ b/fs/afs/callback.c
@@ -461,8 +461,8 @@ static void afs_callback_updater(struct work_struct *work)
  */
 int __init afs_callback_update_init(void)
 {
-	afs_callback_update_worker =
-		create_singlethread_workqueue("kafs_callbackd");
+	afs_callback_update_worker = alloc_ordered_workqueue("kafs_callbackd",
+							     WQ_MEM_RECLAIM);
 	return afs_callback_update_worker ? 0 : -ENOMEM;
 }
 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net-next 0/9] rxrpc: Small fixes David Howells <dhowells@redhat.com> - 2016-09-04 23:10 +0200
  [PATCH net-next 9/9] fs/afs/flock: Remove deprecated  create_singlethread_workqueue David Howells <dhowells@redhat.com> - 2016-09-04 23:10 +0200
  [PATCH net-next 5/9] rxrpc: Don't change the epoch David Howells <dhowells@redhat.com> - 2016-09-04 23:10 +0200
  [PATCH net-next 6/9] fs/afs/vlocation: Remove deprecated  create_singlethread_workqueue David Howells <dhowells@redhat.com> - 2016-09-04 23:20 +0200
  [PATCH net-next 3/9] rxrpc: The client call state must be changed  before attachment to conn David Howells <dhowells@redhat.com> - 2016-09-04 23:20 +0200
  [PATCH net-next 4/9] rxrpc: Randomise epoch and starting client  conn ID values David Howells <dhowells@redhat.com> - 2016-09-04 23:20 +0200
    RE: [PATCH net-next 4/9] rxrpc: Randomise epoch and starting client  conn ID values David Laight <David.Laight@ACULAB.COM> - 2016-09-05 17:10 +0200
      Re: [PATCH net-next 4/9] rxrpc: Randomise epoch and starting client conn ID values David Howells <dhowells@redhat.com> - 2016-09-05 18:30 +0200
        Re: [PATCH net-next 4/9] rxrpc: Randomise epoch and starting client  conn ID values Jeffrey Altman <jaltman@auristor.com> - 2016-09-06 04:20 +0200
  [PATCH net-next 7/9] fs/afs/rxrpc: Remove deprecated  create_singlethread_workqueue David Howells <dhowells@redhat.com> - 2016-09-04 23:20 +0200
  [PATCH net-next 8/9] fs/afs/callback: Remove deprecated  create_singlethread_workqueue David Howells <dhowells@redhat.com> - 2016-09-04 23:20 +0200
  Re: [PATCH net-next 0/9] rxrpc: Small fixes David Miller <davem@davemloft.net> - 2016-09-06 23:00 +0200

csiph-web