Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1474112

[PATCH v8 02/16] of/numa: fix a memory@ node can only contains one memory block

Show key headers only | View raw

For a normal memory@ devicetree node, its reg property can contains more
memory blocks.

Because we don't known how many memory blocks maybe contained, so we try
from index=0, increase 1 until error returned(the end).

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 drivers/of/of_numa.c | 29 ++++++++++-------------------
 1 file changed, 10 insertions(+), 19 deletions(-)

diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c
index fb71b4e..7b3fbdc 100644
--- a/drivers/of/of_numa.c
+++ b/drivers/of/of_numa.c
@@ -63,13 +63,9 @@ static int __init of_numa_parse_memory_nodes(void)
 	struct device_node *np = NULL;
 	struct resource rsrc;
 	u32 nid;
-	int r = 0;
-
-	for (;;) {
-		np = of_find_node_by_type(np, "memory");
-		if (!np)
-			break;
+	int i, r;

+	for_each_node_by_type(np, "memory") {
 		r = of_property_read_u32(np, "numa-node-id", &nid);
 		if (r == -EINVAL)
 			/*
@@ -78,23 +74,18 @@ static int __init of_numa_parse_memory_nodes(void)
 			 * "numa-node-id" property
 			 */
 			continue;
-		else if (r)
-			/* some other error */
-			break;

-		r = of_address_to_resource(np, 0, &rsrc);
-		if (r) {
-			pr_err("NUMA: bad reg property in memory node\n");
-			break;
-		}
+		for (i = 0; !r && !of_address_to_resource(np, i, &rsrc); i++)
+			r = numa_add_memblk(nid, rsrc.start, rsrc.end + 1);

-		r = numa_add_memblk(nid, rsrc.start, rsrc.end + 1);
-		if (r)
-			break;
+		if (!i || r) {
+			of_node_put(np);
+			pr_err("NUMA: bad property in memory node\n");
+			return r ? : -EINVAL;
+		}
 	}
-	of_node_put(np);

-	return r;
+	return 0;
 }

 static int __init of_numa_parse_distance_map_v1(struct device_node *map)
--
2.5.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v8 00/16] fix some type infos and bugs for arm64/of numa Zhen Lei <thunder.leizhen@huawei.com> - 2016-09-01 09:00 +0200
  [PATCH v8 05/16] arm64/numa: avoid inconsistent information to be printed Zhen Lei <thunder.leizhen@huawei.com> - 2016-09-01 09:00 +0200
  [PATCH v8 07/16] of_numa: Use pr_fmt() Zhen Lei <thunder.leizhen@huawei.com> - 2016-09-01 09:00 +0200
  [PATCH v8 04/16] of/numa: remove a duplicated warning Zhen Lei <thunder.leizhen@huawei.com> - 2016-09-01 09:00 +0200
  [PATCH v8 10/16] mm/memblock: add a new function memblock_alloc_near_nid Zhen Lei <thunder.leizhen@huawei.com> - 2016-09-01 09:00 +0200
    Re: [PATCH v8 10/16] mm/memblock: add a new function  memblock_alloc_near_nid "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2016-09-09 06:00 +0200
  [PATCH v8 12/16] arm64/numa: remove some useless code Zhen Lei <thunder.leizhen@huawei.com> - 2016-09-01 09:00 +0200
  [PATCH v8 06/16] of_numa: Use of_get_next_parent to simplify code Zhen Lei <thunder.leizhen@huawei.com> - 2016-09-01 09:00 +0200
  [PATCH v8 16/16] arm64/numa: define numa_distance as array to simplify code Zhen Lei <thunder.leizhen@huawei.com> - 2016-09-01 09:00 +0200
  [PATCH v8 01/16] of/numa: remove a duplicated pr_debug information Zhen Lei <thunder.leizhen@huawei.com> - 2016-09-01 09:10 +0200
  [PATCH v8 02/16] of/numa: fix a memory@ node can only contains one memory block Zhen Lei <thunder.leizhen@huawei.com> - 2016-09-01 09:10 +0200
  Re: [PATCH v8 00/16] fix some type infos and bugs for arm64/of numa Will Deacon <will.deacon@arm.com> - 2016-09-08 13:10 +0200
    Re: [PATCH v8 00/16] fix some type infos and bugs for arm64/of numa "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2016-09-09 04:10 +0200

csiph-web