Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init()

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init()
Date	2016-08-28 20:40 +0200
Message-ID	<sbd9U-5el-7@gated-at.bofh.it> (permalink)
References	(2 earlier) <savsd-2Z5-15@gated-at.bofh.it> <sawxX-3Rz-19@gated-at.bofh.it> <saFUC-1uq-5@gated-at.bofh.it> <saWsp-36o-1@gated-at.bofh.it> <sb4zE-8gH-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, 2016-08-28 at 11:28 +0200, Julia Lawall wrote:

> I do think that there is some value in doing similar things in a uniform
> way, using meaningful names, even if in a particular case it doesn't help
> performance or reduce code size.  Even duplicating code could be OK if it
> is not in a critical path and it makes the code overall easier to
> understand.  But if the maintainer prefers the code not to be duplicated,
> then of course it should not be duplicated.

All true too, thanks Julia.

It's all maintainer choice.

Thread

[PATCH 0/5] IA64: Fine-tuning for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 20:10 +0200
  [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 20:10 +0200
    Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() Julia Lawall <julia.lawall@lip6.fr> - 2016-08-26 22:00 +0200
      Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() Joe Perches <joe@perches.com> - 2016-08-26 23:10 +0200
        Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-27 09:10 +0200
          Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() Joe Perches <joe@perches.com> - 2016-08-28 02:50 +0200
            Re: IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-28 09:40 +0200
            Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() Julia Lawall <julia.lawall@lip6.fr> - 2016-08-28 11:30 +0200
              Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() Joe Perches <joe@perches.com> - 2016-08-28 20:40 +0200
      Re: IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-27 08:30 +0200
    Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() kbuild test robot <lkp@intel.com> - 2016-08-26 22:30 +0200
    Re: [PATCH 1/5] IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init() walter harms <wharms@bfs.de> - 2016-08-27 10:50 +0200
  [PATCH 2/5] IA64-IRQ: Delete unnecessary braces SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 20:20 +0200
    Re: [PATCH 2/5] IA64-IRQ: Delete unnecessary braces kbuild test robot <lkp@intel.com> - 2016-08-26 22:30 +0200
  [PATCH 5/5] ia64/mm/tlb: Delete unnecessary braces SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 20:20 +0200
    Re: [PATCH 5/5] ia64/mm/tlb: Delete unnecessary braces kbuild test robot <lkp@intel.com> - 2016-08-26 22:50 +0200
      Re: ia64/mm/tlb: Delete unnecessary braces SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-27 09:30 +0200
  [PATCH 3/5] ia64/mm/tlb: Fix indentation in ia64_global_tlb_purge() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 20:20 +0200
  [PATCH 4/5] ia64/mm/tlb: Use kmalloc_array() in ia64_itr_entry() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 20:20 +0200

csiph-web